Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jul 25, 2024

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman
Copy link
Contributor Author

run buildall

1 similar comment
@hello-stephen
Copy link
Contributor

run buildall

@morningman morningman changed the title [refactor](catalog) set "use_meta_cache" default to true (#38244)(#38352) [refactor](catalog) set "use_meta_cache" default to true (#38244)(#38352)(#38619) Aug 1, 2024
morningman and others added 2 commits August 1, 2024 13:09
This is PR apache#33610 introduce a new feature of `use_meta_cache=true`.
Now I will set this property default to true.
For all newly created catalog, is this property is not specified, it
will be true.
For all previously created catalog, this property is still false.
…#38619)

Brought by: apache#38244

how to reproduce:
create a hms catalog named hive with property use_meta_cache = false,
after that restart fe, and run sql `switch hive; show databases;`, will
get error:
```sql
ERROR 1105 (HY000): NullPointerException, msg: java.lang.NullPointerException: Cannot invoke "org.apache.doris.datasource.metacache.MetaCache.listNames()" because "this.metaCache" is null
```

reason, property use_meta_cache of newly created hms catalog after pr
apache#38244 was force convert to true, but field `useMetaCache` of class
ExternalCatalog is not converted at the same time.
@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@morningman morningman merged commit da7b2cf into apache:branch-2.1 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants