-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](multicatalog) fix metacache is null issue when show_dbs #38619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41928 ms |
TPC-DS: Total hot run time: 170811 ms |
ClickBench: Total hot run time: 30.01 s |
|
run cloud_p0 |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…#38619) Brought by: apache#38244 how to reproduce: create a hms catalog named hive with property use_meta_cache = false, after that restart fe, and run sql `switch hive; show databases;`, will get error: ```sql ERROR 1105 (HY000): NullPointerException, msg: java.lang.NullPointerException: Cannot invoke "org.apache.doris.datasource.metacache.MetaCache.listNames()" because "this.metaCache" is null ``` reason, property use_meta_cache of newly created hms catalog after pr apache#38244 was force convert to true, but field `useMetaCache` of class ExternalCatalog is not converted at the same time.
…#38619) Brought by: apache#38244 how to reproduce: create a hms catalog named hive with property use_meta_cache = false, after that restart fe, and run sql `switch hive; show databases;`, will get error: ```sql ERROR 1105 (HY000): NullPointerException, msg: java.lang.NullPointerException: Cannot invoke "org.apache.doris.datasource.metacache.MetaCache.listNames()" because "this.metaCache" is null ``` reason, property use_meta_cache of newly created hms catalog after pr apache#38244 was force convert to true, but field `useMetaCache` of class ExternalCatalog is not converted at the same time.
Brought by: #38244 how to reproduce: create a hms catalog named hive with property use_meta_cache = false, after that restart fe, and run sql `switch hive; show databases;`, will get error: ```sql ERROR 1105 (HY000): NullPointerException, msg: java.lang.NullPointerException: Cannot invoke "org.apache.doris.datasource.metacache.MetaCache.listNames()" because "this.metaCache" is null ``` reason, property use_meta_cache of newly created hms catalog after pr #38244 was force convert to true, but field `useMetaCache` of class ExternalCatalog is not converted at the same time.
Brought by: #38244 how to reproduce: create a hms catalog named hive with property use_meta_cache = false, after that restart fe, and run sql `switch hive; show databases;`, will get error: ```sql ERROR 1105 (HY000): NullPointerException, msg: java.lang.NullPointerException: Cannot invoke "org.apache.doris.datasource.metacache.MetaCache.listNames()" because "this.metaCache" is null ``` reason, property use_meta_cache of newly created hms catalog after pr #38244 was force convert to true, but field `useMetaCache` of class ExternalCatalog is not converted at the same time.
Brought by: #38244
how to reproduce:
create a hms catalog named hive with property use_meta_cache = false, after that restart fe, and run sql
switch hive; show databases;, will get error:reason, property use_meta_cache of newly created hms catalog after pr #38244 was force convert to true, but field
useMetaCacheof class ExternalCatalog is not converted at the same time.