[Bug] Fix bug that BE crash when doing Insert Operation #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
area/load
wutiangan
reviewed
Jun 15, 2020
| PExecPlanFragmentResult result = new PExecPlanFragmentResult(); | ||
| PStatus pStatus = new PStatus(); | ||
| pStatus.error_msgs.add(e.getMessage()); | ||
| // use THRIFT_RPC_ERROR so that this BE will be added to the black list later. |
Contributor
There was a problem hiding this comment.
black list --> blacklist
morningman
force-pushed
the
insert_load_core
branch
from
ce38590 to
b0cb04e
Compare
Contributor
@morningman Hi, where is the code? |
Contributor
Author
Oh, sorry, I think i miss some part of the code... |
Contributor
Author
Done |
Contributor
Author
|
hi @kangkaisen Could you help to review again? |
Contributor
|
OK |
kangkaisen
reviewed
Jun 17, 2020
morningman
force-pushed
the
insert_load_core
branch
from
5a73cc2 to
a9201ab
Compare
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 20, 2020
Mainly change: 1. Fix the bug in `update_status(status)` of `PlanFragmentExecutor`. 2. When the FE Coordinator executes `execRemoteFragmentAsync()`, if it finds an RPC error, return a Future with an error code instead of exception. 3. Protect the `_status` in RuntimeState with lock 4. Move the `_runtime_profile` of RuntimeState before the `_obj_pool`, so that the profile will be deconstructed after the object pool. 5. Remove the unused `ObjectPool` param in RuntimeProfile constructor. If I don't remove it, RuntimeProfile will depends on the `_obj_pool` in RuntimeProfile.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 22, 2020
Mainly change: 1. Fix the bug in `update_status(status)` of `PlanFragmentExecutor`. 2. When the FE Coordinator executes `execRemoteFragmentAsync()`, if it finds an RPC error, return a Future with an error code instead of exception. 3. Protect the `_status` in RuntimeState with lock 4. Move the `_runtime_profile` of RuntimeState before the `_obj_pool`, so that the profile will be deconstructed after the object pool. 5. Remove the unused `ObjectPool` param in RuntimeProfile constructor. If I don't remove it, RuntimeProfile will depends on the `_obj_pool` in RuntimeProfile.
morningman
added a commit
that referenced
this pull request
Jun 25, 2020
This bug is introduced by #3872. It will cause some expected to be cancelled queries not being cancelled.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 28, 2020
This bug is introduced by apache#3872. It will cause some expected to be cancelled queries not being cancelled.
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3871
Mainly change:
update_status(status)ofPlanFragmentExecutor.execRemoteFragmentAsync(), if it finds an RPC error, return a Future with an error code instead of exception._statusin RuntimeState with lock_runtime_profileof RuntimeState before the_obj_pool, so that the profile will bedeconstructed after the object pool.
ObjectPoolparam in RuntimeProfile constructor. If I don't remove it,RuntimeProfile will depends on the
_obj_poolin RuntimeProfile.