[Bug] Fix bug that a query plan is not correctly cancelled #3933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/fix
chaoyli
requested changes
Jun 24, 2020
| @@ -487,21 +487,22 @@ Status PlanFragmentExecutor::get_next_internal(RowBatch** batch) { | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Only rename status to new_status?
Contributor
Author
There was a problem hiding this comment.
See changes in line 497 if (_status.ok())
chaoyli
approved these changes
Jun 25, 2020
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 28, 2020
This bug is introduced by apache#3872. It will cause some expected to be cancelled queries not being cancelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is introduced by #3872.
It will cause some expected to be cancelled queries not being cancelled.