[fix](compaction) fix the longest continuous rowsets cannot be selected when missing rowsets #38728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed when missing rowsets
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "olap/cumulative_compaction.h" |
Contributor
There was a problem hiding this comment.
warning: 'olap/cumulative_compaction.h' file not found [clang-diagnostic-error]
#include "olap/cumulative_compaction.h"
^| return rowset; | ||
| } | ||
|
|
||
| TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) { |
Contributor
There was a problem hiding this comment.
warning: function 'TEST_F' exceeds recommended size/complexity thresholds [readability-function-size]
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^Additional context
be/test/olap/cumulative_compaction_test.cpp:66: 142 lines including whitespace and comments (threshold 80)
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41477 ms |
TPC-DS: Total hot run time: 169981 ms |
ClickBench: Total hot run time: 29.99 s |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
| return rowset; | ||
| } | ||
|
|
||
| TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) { |
Contributor
There was a problem hiding this comment.
warning: function 'TEST_F' exceeds recommended size/complexity thresholds [readability-function-size]
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^Additional context
be/test/olap/cumulative_compaction_test.cpp:66: 197 lines including whitespace and comments (threshold 80)
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^
TPC-H: Total hot run time: 41558 ms |
TPC-DS: Total hot run time: 169386 ms |
ClickBench: Total hot run time: 30.07 s |
bobhan1
approved these changes
Aug 4, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…ed when missing rowsets (#38728) ### problem When version is missing, the code for selecting the longest continuous version has a bug. Only the version before the missing version will be selected. For example: the current version is version [1-1], version [2-2], version [4-4], version [5-5], version [6-6], version [7-7], and version [3-3] is missing. The current result is to return version [1-1], version [2-2] instead of version [4-4], version [5-5], version [6-6], version [7-7]
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Aug 13, 2024
…ed when missing rowsets (apache#38728) When version is missing, the code for selecting the longest continuous version has a bug. Only the version before the missing version will be selected. For example: the current version is version [1-1], version [2-2], version [4-4], version [5-5], version [6-6], version [7-7], and version [3-3] is missing. The current result is to return version [1-1], version [2-2] instead of version [4-4], version [5-5], version [6-6], version [7-7]
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…ed when missing rowsets (#38728) ### problem When version is missing, the code for selecting the longest continuous version has a bug. Only the version before the missing version will be selected. For example: the current version is version [1-1], version [2-2], version [4-4], version [5-5], version [6-6], version [7-7], and version [3-3] is missing. The current result is to return version [1-1], version [2-2] instead of version [4-4], version [5-5], version [6-6], version [7-7]
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Sep 4, 2024
…e selected when missing rowsets (apache#38728) (apache#39262)" This reverts commit c9949f2. This pr may increase the probability of full clone failure, so revert it first.
yiguolei
pushed a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
When version is missing, the code for selecting the longest continuous version has a bug. Only the version before the missing version will be selected.
For example: the current version is version [1-1], version [2-2], version [4-4], version [5-5], version [6-6], version [7-7], and version [3-3] is missing.
The current result is to return version [1-1], version [2-2] instead of version [4-4], version [5-5], version [6-6], version [7-7]