[fix](compaction) fix the longest continuous rowsets cannot be selected when missing rowsets (#38728) #39262
Conversation
…ed when missing rowsets (apache#38728) When version is missing, the code for selecting the longest continuous version has a bug. Only the version before the missing version will be selected. For example: the current version is version [1-1], version [2-2], version [4-4], version [5-5], version [6-6], version [7-7], and version [3-3] is missing. The current result is to return version [1-1], version [2-2] instead of version [4-4], version [5-5], version [6-6], version [7-7]
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "olap/cumulative_compaction.h" |
There was a problem hiding this comment.
warning: 'olap/cumulative_compaction.h' file not found [clang-diagnostic-error]
#include "olap/cumulative_compaction.h"
^| return rowset; | ||
| } | ||
|
|
||
| TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) { |
There was a problem hiding this comment.
warning: function 'TEST_F' exceeds recommended size/complexity thresholds [readability-function-size]
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^Additional context
be/test/olap/cumulative_compaction_test.cpp:66: 197 lines including whitespace and comments (threshold 80)
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^
|
run buildall |
| return rowset; | ||
| } | ||
|
|
||
| TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) { |
There was a problem hiding this comment.
warning: function 'TEST_F' exceeds recommended size/complexity thresholds [readability-function-size]
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^Additional context
be/test/olap/cumulative_compaction_test.cpp:65: 197 lines including whitespace and comments (threshold 80)
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^
|
run buildall |
| return rowset; | ||
| } | ||
|
|
||
| TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) { |
There was a problem hiding this comment.
warning: function 'TEST_F' exceeds recommended size/complexity thresholds [readability-function-size]
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^Additional context
be/test/olap/cumulative_compaction_test.cpp:65: 206 lines including whitespace and comments (threshold 80)
TEST_F(CumulativeCompactionTest, TestConsecutiveVersion) {
^
|
TeamCity be ut coverage result: |
…e selected when missing rowsets (apache#38728) (apache#39262)" This reverts commit c9949f2. This pr may increase the probability of full clone failure, so revert it first.
3 participants
pick master #38728