-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](catalog) refactor location path and support default fs #39116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 39738 ms |
TPC-DS: Total hot run time: 203774 ms |
ClickBench: Total hot run time: 30.7 s |
af331af to
4382420
Compare
|
run buildall |
TPC-H: Total hot run time: 39406 ms |
TPC-DS: Total hot run time: 201384 ms |
ClickBench: Total hot run time: 31.55 s |
|
run buildall |
TPC-H: Total hot run time: 39736 ms |
TPC-DS: Total hot run time: 199407 ms |
ClickBench: Total hot run time: 30.14 s |
wsjz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
kaka11chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…39116) `LocationPath` is used for normalizing the path uri of files of external table. But previouly, we use `LocationPath` every where and it is a very heavy operation. This PR refactor the logic as follow: 1. The `LocationPath` will once be used once when generating file split, and it will be saved in FileSplit. 2. All following logic will reuse the `LocationPath` in file split.
### What problem does this PR solve? Related PR: #39116 Problem Summary: Split and get the schema according to `://` and `:/`. Like `file://ab/c`, `file:/ab/c`
### What problem does this PR solve? Related PR: #39116 Problem Summary: Split and get the schema according to `://` and `:/`. Like `file://ab/c`, `file:/ab/c`
### What problem does this PR solve? Related PR: #39116 Problem Summary: Split and get the schema according to `://` and `:/`. Like `file://ab/c`, `file:/ab/c`
LocationPathis used for normalizing the path uri of files of external table.But previouly, we use
LocationPathevery where and it is a very heavy operation.This PR refactor the logic as follow:
LocationPathwill once be used once when generating file split, and it will be saved in FileSplit.LocationPathin file split.