Skip to content

Conversation

@wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented Dec 13, 2024

What problem does this PR solve?

Related PR: #39116

Problem Summary:

Split and get the schema according to :// and :/.
Like file://ab/c, file:/ab/c

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 13, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wuwenchi
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 15, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 36230be into apache:master Dec 17, 2024
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
### What problem does this PR solve?

Related PR: #39116

Problem Summary:

Split and get the schema according to `://` and `:/`.
Like `file://ab/c`, `file:/ab/c`
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
### What problem does this PR solve?

Related PR: #39116

Problem Summary:

Split and get the schema according to `://` and `:/`.
Like `file://ab/c`, `file:/ab/c`
yiguolei pushed a commit that referenced this pull request Dec 19, 2024
Cherry-picked from #45408

Co-authored-by: wuwenchi <wuwenchi@selectdb.com>
morningman pushed a commit that referenced this pull request Dec 31, 2024
Cherry-picked from #45408

Co-authored-by: wuwenchi <wuwenchi@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants