[fix](schema-change) Fix potential data race when a schema change jobs is set to cancelled but the table state is still SCHEMA_CHANGE (#39164) #39327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s is set to cancelled but the table state is still SCHEMA_CHANGE (apache#39164) Set job cancel state after table state changed to normal.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Nov 4, 2024
…is changed (apache#42670) Similar to apache#39327 Note that schema change job state and table state should be atomic and persistent, but neither is ensured by current implementation. We should optimize this point in the future.
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Nov 4, 2024
…is changed (apache#42670) Similar to apache#39327 Note that schema change job state and table state should be atomic and persistent, but neither is ensured by current implementation. We should optimize this point in the future.
dataroaring
pushed a commit
that referenced
this pull request
Nov 7, 2024
…table state is changed (#42879) PR Body: ## Proposed changes Similar to #39327 Note that schema change job state and table state should be atomic and persistent, but neither is ensured by current implementation. We should optimize this point in the future. Cherry-picked from #42670 Co-authored-by: Siyang Tang <82279870+TangSiyang2001@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Set job cancel state after table state changed to normal.