-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](file cache) Fix data race of rowset meta when download segment data #39361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dataroaring
merged 1 commit into
apache:master
from
gavinchou:gavin-fix-file-cache-snapshot-rowset-meta
Aug 15, 2024
Merged
[fix](file cache) Fix data race of rowset meta when download segment data #39361
dataroaring
merged 1 commit into
apache:master
from
gavinchou:gavin-fix-file-cache-snapshot-rowset-meta
Aug 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data The original impl. _rs_metas is not protected correctly when doing traversal. We have to access the rowset meta via tablet level interface to ensure integrity.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
platoneko
approved these changes
Aug 14, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37782 ms |
TPC-DS: Total hot run time: 184346 ms |
ClickBench: Total hot run time: 31.38 s |
bobhan1
approved these changes
Aug 14, 2024
Yukang-Lian
approved these changes
Aug 14, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
…data (#39361) The original impl. _rs_metas is not protected correctly when doing traversal. We have to access the rowset meta via tablet level interface to ensure integrity.
Closed
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Nov 12, 2024
…data (apache#39361) The original impl. _rs_metas is not protected correctly when doing traversal. We have to access the rowset meta via tablet level interface to ensure integrity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original impl. _rs_metas is not protected correctly when doing traversal. We have to access the rowset meta via tablet level interface to ensure integrity.