Skip to content

Conversation

@gavinchou
Copy link
Contributor

The original impl. _rs_metas is not protected correctly when doing traversal. We have to access the rowset meta via tablet level interface to ensure integrity.

…data

The original impl. _rs_metas is not protected correctly when doing traversal.
We have to access the rowset meta via tablet level interface to ensure integrity.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 14, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37782 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be1109098be4d1bca1df5fa7c94d78f6faa76aef, data reload: false

------ Round 1 ----------------------------------
q1	17607	4578	4372	4372
q2	2021	185	189	185
q3	10464	1234	1100	1100
q4	10139	768	782	768
q5	7739	2848	2808	2808
q6	227	140	148	140
q7	962	591	610	591
q8	9333	2041	2083	2041
q9	7120	6566	6568	6566
q10	7067	2182	2176	2176
q11	471	245	249	245
q12	391	229	222	222
q13	17772	2982	2989	2982
q14	280	234	231	231
q15	513	495	481	481
q16	503	389	381	381
q17	972	632	721	632
q18	7578	6849	6729	6729
q19	6651	1157	1003	1003
q20	684	324	319	319
q21	3785	2809	2826	2809
q22	1104	1013	1001	1001
Total cold run time: 113383 ms
Total hot run time: 37782 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4526	4257	4294	4257
q2	372	270	255	255
q3	2905	2662	2619	2619
q4	1906	1579	1620	1579
q5	5468	5397	5377	5377
q6	217	128	134	128
q7	2056	1695	1671	1671
q8	3199	3322	3342	3322
q9	8490	8310	8443	8310
q10	3405	3160	3126	3126
q11	624	494	507	494
q12	767	631	604	604
q13	17475	2993	2975	2975
q14	305	266	272	266
q15	520	476	476	476
q16	469	420	421	420
q17	1790	1504	1457	1457
q18	7685	7520	7500	7500
q19	1689	1594	1599	1594
q20	1989	1797	1838	1797
q21	5274	5091	4953	4953
q22	1078	1003	999	999
Total cold run time: 72209 ms
Total hot run time: 54179 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184346 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be1109098be4d1bca1df5fa7c94d78f6faa76aef, data reload: false

query1	903	381	362	362
query2	6466	2090	1939	1939
query3	6650	207	224	207
query4	33896	23195	23025	23025
query5	4172	481	474	474
query6	280	168	163	163
query7	4600	292	285	285
query8	262	201	197	197
query9	8538	2442	2413	2413
query10	435	265	263	263
query11	15994	15062	15001	15001
query12	145	102	96	96
query13	1632	365	365	365
query14	9483	6769	7043	6769
query15	209	168	175	168
query16	7709	494	458	458
query17	1375	561	532	532
query18	1921	288	272	272
query19	185	140	135	135
query20	112	105	104	104
query21	210	103	102	102
query22	4202	4107	3897	3897
query23	34009	33151	33397	33151
query24	12278	2803	2806	2803
query25	658	369	363	363
query26	1842	154	155	154
query27	3046	271	270	270
query28	7819	2049	2056	2049
query29	1142	398	398	398
query30	301	147	152	147
query31	966	746	752	746
query32	91	54	58	54
query33	744	287	284	284
query34	976	462	459	459
query35	880	692	724	692
query36	1116	911	893	893
query37	283	82	80	80
query38	3999	3808	3891	3808
query39	1435	1373	1403	1373
query40	269	118	113	113
query41	44	42	45	42
query42	115	96	101	96
query43	506	492	485	485
query44	1166	729	718	718
query45	192	167	165	165
query46	1114	757	761	757
query47	1860	1785	1791	1785
query48	363	280	284	280
query49	1218	407	421	407
query50	794	410	396	396
query51	6674	6718	6701	6701
query52	101	88	89	88
query53	250	182	188	182
query54	969	446	447	446
query55	75	72	76	72
query56	260	242	241	241
query57	1148	1079	1046	1046
query58	234	223	221	221
query59	3208	2763	2934	2763
query60	292	256	262	256
query61	95	93	99	93
query62	846	630	649	630
query63	216	184	184	184
query64	6324	2293	1749	1749
query65	3444	3179	3128	3128
query66	1358	349	337	337
query67	15368	14812	14737	14737
query68	4861	546	542	542
query69	552	360	280	280
query70	1151	1110	1181	1110
query71	449	276	272	272
query72	6571	2267	1994	1994
query73	781	318	321	318
query74	9042	8721	8773	8721
query75	3612	2701	2717	2701
query76	3415	976	953	953
query77	731	313	318	313
query78	10177	9135	8954	8954
query79	2963	517	528	517
query80	2016	486	505	486
query81	587	230	231	230
query82	1053	141	138	138
query83	310	146	148	146
query84	283	77	78	77
query85	1289	285	272	272
query86	450	294	297	294
query87	4425	4376	4241	4241
query88	4020	2315	2304	2304
query89	399	291	297	291
query90	1910	199	196	196
query91	119	94	96	94
query92	60	48	49	48
query93	3362	520	518	518
query94	874	291	293	291
query95	340	256	254	254
query96	598	277	272	272
query97	3193	3022	3064	3022
query98	220	198	195	195
query99	1808	1233	1257	1233
Total cold run time: 301088 ms
Total hot run time: 184346 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be1109098be4d1bca1df5fa7c94d78f6faa76aef, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.71	0.08	0.07
query5	0.51	0.48	0.51
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.48
query10	0.55	0.55	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.59
query14	0.78	0.78	0.79
query15	0.87	0.83	0.83
query16	0.38	0.39	0.38
query17	1.01	0.97	1.05
query18	0.22	0.21	0.22
query19	1.91	1.88	1.78
query20	0.01	0.02	0.01
query21	15.44	0.76	0.67
query22	4.74	6.11	2.22
query23	18.28	1.33	1.28
query24	3.23	0.27	0.25
query25	0.31	0.10	0.09
query26	0.54	0.22	0.22
query27	1.17	0.26	0.25
query28	15.06	1.09	1.07
query29	14.07	3.49	3.41
query30	0.45	0.05	0.04
query31	3.74	0.39	0.38
query32	3.48	0.48	0.48
query33	2.98	3.03	2.96
query34	17.06	4.34	4.51
query35	4.40	4.41	4.41
query36	0.65	0.49	0.46
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.14	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.05
Total cold run time: 117.3 s
Total hot run time: 31.38 s

@dataroaring dataroaring merged commit 1509533 into apache:master Aug 15, 2024
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
…data (#39361)

The original impl. _rs_metas is not protected correctly when doing
traversal. We have to access the rowset meta via tablet level interface
to ensure integrity.
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Nov 12, 2024
…data (apache#39361)

The original impl. _rs_metas is not protected correctly when doing
traversal. We have to access the rowset meta via tablet level interface
to ensure integrity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.2-merged doing reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants