Skip to content

[fix](Nereids) fix explain plan with sql cache #39431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
924060929 merged 3 commits into from
Aug 16, 2024
Merged

[fix](Nereids) fix explain plan with sql cache #39431

924060929 merged 3 commits into from
Aug 16, 2024

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Aug 15, 2024

Proposed changes

introduced by #38950, explain plan with sql cache will throw an exception

errCode = 2, detailMessage = Cannot invoke "org.apache.doris.nereids.trees.plans.Plan.treeString()" because "this.optimizedPlan" is null

@doris-robot
Copy link

doris-robot commented Aug 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@924060929
Copy link
Contributor Author

924060929 commented Aug 15, 2024

run buildall

@924060929 924060929 changed the title [fix](Nereids) fix explain sql cache [fix](Nereids) fix explain plan with sql cache Aug 15, 2024
@doris-robot
Copy link

doris-robot commented Aug 15, 2024

TPC-H: Total hot run time: 37769 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 391437a708774bf654fe4b49522c2a75611667d9, data reload: false

------ Round 1 ----------------------------------
q1	17873	4365	4293	4293
q2	2056	207	227	207
q3	11702	1085	1219	1085
q4	10519	802	780	780
q5	7824	2853	2876	2853
q6	273	158	160	158
q7	1022	651	654	651
q8	9588	2047	2102	2047
q9	8414	6495	6550	6495
q10	7058	2343	2277	2277
q11	464	256	260	256
q12	413	239	242	239
q13	17941	2985	2956	2956
q14	289	248	248	248
q15	555	513	514	513
q16	523	395	407	395
q17	990	595	771	595
q18	7336	6829	6672	6672
q19	5374	1096	1109	1096
q20	685	367	371	367
q21	3910	2958	2570	2570
q22	1083	1016	1051	1016
Total cold run time: 115892 ms
Total hot run time: 37769 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4528	4253	4270	4253
q2	427	289	293	289
q3	2825	2601	2621	2601
q4	1969	1677	1669	1669
q5	5657	5635	5720	5635
q6	240	146	145	145
q7	2206	1797	1799	1797
q8	3323	3551	3467	3467
q9	8725	8684	8675	8675
q10	3563	3373	3329	3329
q11	636	532	544	532
q12	863	656	663	656
q13	15855	3136	3148	3136
q14	339	302	302	302
q15	564	511	518	511
q16	500	441	446	441
q17	1789	1569	1532	1532
q18	8285	7748	7741	7741
q19	10299	1690	1728	1690
q20	3502	1895	1846	1846
q21	10999	5396	5409	5396
q22	1141	1091	1089	1089
Total cold run time: 88235 ms
Total hot run time: 56732 ms

@doris-robot
Copy link

doris-robot commented Aug 15, 2024

TPC-DS: Total hot run time: 196090 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 391437a708774bf654fe4b49522c2a75611667d9, data reload: false

query1	1361	925	865	865
query2	6553	1989	1924	1924
query3	10640	3845	3997	3845
query4	55122	24417	23228	23228
query5	5678	705	695	695
query6	558	211	205	205
query7	6436	309	308	308
query8	467	362	361	361
query9	9154	2497	2474	2474
query10	564	317	326	317
query11	18319	15020	15118	15020
query12	195	131	134	131
query13	1724	429	422	422
query14	11823	7299	6867	6867
query15	257	206	195	195
query16	7704	570	553	553
query17	1196	648	614	614
query18	2097	350	348	348
query19	292	175	168	168
query20	145	134	133	133
query21	252	141	139	139
query22	4581	4520	4393	4393
query23	34368	33877	33856	33856
query24	5721	3004	3000	3000
query25	593	443	450	443
query26	716	182	181	181
query27	1930	302	308	302
query28	3940	2185	2180	2180
query29	741	461	455	455
query30	233	181	192	181
query31	1033	844	844	844
query32	112	77	77	77
query33	488	415	362	362
query34	923	507	507	507
query35	878	805	783	783
query36	1105	974	970	970
query37	159	108	106	106
query38	3932	3854	3856	3854
query39	1525	1457	1508	1457
query40	243	157	154	154
query41	143	138	139	138
query42	134	117	118	117
query43	523	512	514	512
query44	1105	777	774	774
query45	219	192	190	190
query46	1104	790	770	770
query47	1915	1795	1846	1795
query48	406	331	340	331
query49	912	590	577	577
query50	861	464	455	455
query51	6892	6817	6647	6647
query52	124	113	115	113
query53	305	226	228	226
query54	614	505	501	501
query55	93	91	90	90
query56	338	317	312	312
query57	1204	1106	1148	1106
query58	315	340	305	305
query59	2917	2823	2878	2823
query60	367	334	322	322
query61	151	153	182	153
query62	791	693	702	693
query63	257	225	224	224
query64	3287	1845	1864	1845
query65	3261	3163	3192	3163
query66	1049	677	698	677
query67	15223	14931	14631	14631
query68	6869	586	580	580
query69	667	415	342	342
query70	1234	1176	1162	1162
query71	518	359	319	319
query72	6809	2333	2116	2116
query73	818	357	355	355
query74	9500	8695	8831	8695
query75	3858	2767	2745	2745
query76	3415	998	1075	998
query77	821	440	444	440
query78	9723	9928	9876	9876
query79	7756	555	563	555
query80	1112	682	618	618
query81	619	258	262	258
query82	666	163	164	163
query83	262	213	219	213
query84	288	98	108	98
query85	974	376	361	361
query86	339	337	330	330
query87	4411	4268	4209	4209
query88	4458	2496	2476	2476
query89	545	335	328	328
query90	2086	240	228	228
query91	161	126	129	126
query92	85	78	76	76
query93	4533	540	543	540
query94	739	327	327	327
query95	392	304	306	304
query96	619	289	288	288
query97	3223	3079	3039	3039
query98	244	272	228	228
query99	1577	1301	1290	1290
Total cold run time: 327589 ms
Total hot run time: 196090 ms

@doris-robot
Copy link

doris-robot commented Aug 15, 2024

ClickBench: Total hot run time: 30.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 391437a708774bf654fe4b49522c2a75611667d9, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.05	0.05
query3	0.23	0.05	0.06
query4	1.68	0.08	0.08
query5	0.49	0.51	0.50
query6	1.13	0.74	0.72
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.54	0.50	0.49
query10	0.55	0.56	0.56
query11	0.16	0.13	0.12
query12	0.16	0.13	0.13
query13	0.61	0.62	0.59
query14	0.77	0.78	0.81
query15	0.87	0.84	0.81
query16	0.36	0.37	0.38
query17	1.03	0.98	1.01
query18	0.23	0.22	0.22
query19	1.79	1.77	1.68
query20	0.01	0.01	0.01
query21	15.39	0.85	0.66
query22	4.82	7.58	1.49
query23	18.30	1.36	1.33
query24	2.11	0.21	0.22
query25	0.16	0.09	0.08
query26	0.30	0.22	0.21
query27	0.46	0.23	0.22
query28	13.36	1.05	1.00
query29	12.64	3.34	3.24
query30	0.38	0.19	0.20
query31	2.82	0.41	0.41
query32	3.24	0.50	0.49
query33	2.95	2.97	2.96
query34	17.29	4.30	4.36
query35	4.46	4.39	4.38
query36	0.67	0.50	0.49
query37	0.21	0.18	0.18
query38	0.17	0.18	0.17
query39	0.06	0.06	0.06
query40	0.19	0.16	0.16
query41	0.11	0.07	0.08
query42	0.08	0.07	0.07
query43	0.07	0.06	0.06
Total cold run time: 111.05 s
Total hot run time: 30.68 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2024

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit afa5684 into apache:master Aug 16, 2024
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Aug 16, 2024
@924060929
[fix](Nereids) fix explain plan with sql cache (apache#39431)
5dabece 
introduced by apache#38950, explain plan with sql cache will throw an
exception
```
errCode = 2, detailMessage = Cannot invoke "org.apache.doris.nereids.trees.plans.Plan.treeString()" because "this.optimizedPlan" is null
```

(cherry picked from commit afa5684)
@924060929 924060929 mentioned this pull request Aug 16, 2024
Merged
924060929 added a commit that referenced this pull request Aug 16, 2024
@924060929
[fix](Nereids) fix explain plan with sql cache (#39431) (#39463)
e249e00 
introduced by #38950, explain plan with sql cache will throw an exception
```
errCode = 2, detailMessage = Cannot invoke "org.apache.doris.nereids.trees.plans.Plan.treeString()" because "this.optimizedPlan" is null
```
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@924060929 @dataroaring
[fix](Nereids) fix explain plan with sql cache (#39431)
9160e5a 
introduced by #38950, explain plan with sql cache will throw an
exception
```
errCode = 2, detailMessage = Cannot invoke "org.apache.doris.nereids.trees.plans.Plan.treeString()" because "this.optimizedPlan" is null
```
@924060929 924060929 mentioned this pull request Aug 20, 2024
Merged
924060929 pushed a commit that referenced this pull request Aug 20, 2024
@englefly
[fix](nereids) bug: with sql cache, cascadeContext could be null (#39510
9a06866 
)

fix thown npe because of conflict between #39431 and #39265
dataroaring pushed a commit that referenced this pull request Aug 20, 2024
@englefly @dataroaring
[fix](nereids) bug: with sql cache, cascadeContext could be null (#39510
f04bdf3 
)

fix thown npe because of conflict between #39431 and #39265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@924060929 @doris-robot @starocean999 @morrySnow @dataroaring