Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Aug 16, 2024

Proposed changes

fix thown npe because of conflict between #39431 and #39265

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@englefly
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 37732 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c6c74c5e4c551a6c5f213a7b4cfdb456cf2cc4a9, data reload: false

------ Round 1 ----------------------------------
q1	17845	4456	4278	4278
q2	2045	203	204	203
q3	11737	970	1173	970
q4	10546	755	841	755
q5	7786	2827	2828	2827
q6	263	158	154	154
q7	1035	646	638	638
q8	9594	2092	2098	2092
q9	8720	6544	6583	6544
q10	7028	2170	2231	2170
q11	469	260	254	254
q12	412	242	239	239
q13	18077	2977	2972	2972
q14	284	250	260	250
q15	550	524	511	511
q16	518	422	391	391
q17	986	645	711	645
q18	7354	6716	6755	6716
q19	6120	1098	1087	1087
q20	722	347	344	344
q21	3913	2993	2659	2659
q22	1147	1033	1048	1033
Total cold run time: 117151 ms
Total hot run time: 37732 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4590	4314	4259	4259
q2	402	289	299	289
q3	2829	2639	2601	2601
q4	1973	1730	1651	1651
q5	5637	5710	5748	5710
q6	236	150	144	144
q7	2182	1770	1772	1770
q8	3296	3487	3465	3465
q9	8735	8754	8756	8754
q10	3504	3386	3346	3346
q11	643	534	547	534
q12	877	661	649	649
q13	17059	3196	3156	3156
q14	324	285	293	285
q15	553	511	511	511
q16	490	436	454	436
q17	1819	1563	1516	1516
q18	8253	7839	7737	7737
q19	5602	1677	1615	1615
q20	2209	1902	1875	1875
q21	14312	5322	5297	5297
q22	1169	1126	1110	1110
Total cold run time: 86694 ms
Total hot run time: 56710 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195746 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c6c74c5e4c551a6c5f213a7b4cfdb456cf2cc4a9, data reload: false

query1	1334	917	880	880
query2	6575	2049	2080	2049
query3	10640	3799	3689	3689
query4	57265	24973	23302	23302
query5	5817	715	713	713
query6	548	215	213	213
query7	6397	325	339	325
query8	559	448	451	448
query9	9194	2523	2509	2509
query10	586	352	327	327
query11	18804	15102	15515	15102
query12	197	144	142	142
query13	1676	428	452	428
query14	11791	7242	7279	7242
query15	303	196	195	195
query16	7644	513	552	513
query17	1377	636	605	605
query18	2123	337	332	332
query19	295	174	169	169
query20	151	138	140	138
query21	248	141	142	141
query22	4615	4281	4388	4281
query23	34753	33777	33790	33777
query24	5699	3030	3002	3002
query25	581	450	425	425
query26	716	182	180	180
query27	1902	313	303	303
query28	4121	2187	2166	2166
query29	737	459	451	451
query30	232	190	186	186
query31	1006	835	814	814
query32	99	76	79	76
query33	495	343	362	343
query34	896	492	489	489
query35	874	754	752	752
query36	1108	983	979	979
query37	156	101	104	101
query38	3945	3808	3852	3808
query39	1523	1464	1454	1454
query40	234	155	150	150
query41	139	136	138	136
query42	139	117	114	114
query43	554	535	537	535
query44	1111	777	787	777
query45	226	207	200	200
query46	1113	776	776	776
query47	1914	1872	1817	1817
query48	421	339	331	331
query49	916	580	563	563
query50	860	464	472	464
query51	6872	6800	6627	6627
query52	120	107	108	107
query53	323	221	222	221
query54	629	502	503	502
query55	89	86	96	86
query56	325	302	310	302
query57	1205	1143	1104	1104
query58	293	302	300	300
query59	3223	2881	2851	2851
query60	346	323	317	317
query61	148	149	143	143
query62	792	677	689	677
query63	254	224	227	224
query64	3346	1904	1860	1860
query65	3236	3197	3188	3188
query66	1084	671	665	665
query67	15084	14975	14999	14975
query68	5936	582	573	573
query69	484	313	313	313
query70	1258	1122	1151	1122
query71	534	318	317	317
query72	6696	2291	2158	2158
query73	811	352	355	352
query74	9184	8731	8885	8731
query75	3631	2754	2730	2730
query76	3094	1056	961	961
query77	702	437	443	437
query78	10006	9007	9153	9007
query79	4053	556	552	552
query80	2916	610	613	610
query81	616	261	264	261
query82	798	169	163	163
query83	374	213	218	213
query84	293	97	97	97
query85	1343	360	355	355
query86	444	302	314	302
query87	4445	4147	4264	4147
query88	4664	2522	2491	2491
query89	451	321	323	321
query90	1821	229	234	229
query91	159	132	128	128
query92	90	77	76	76
query93	5134	551	545	545
query94	771	327	329	327
query95	384	296	305	296
query96	630	288	282	282
query97	3263	3081	3111	3081
query98	249	232	233	232
query99	1611	1322	1276	1276
Total cold run time: 328823 ms
Total hot run time: 195746 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c6c74c5e4c551a6c5f213a7b4cfdb456cf2cc4a9, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.05	0.05
query3	0.23	0.05	0.06
query4	1.66	0.08	0.08
query5	0.50	0.50	0.48
query6	1.14	0.74	0.72
query7	0.02	0.02	0.02
query8	0.06	0.05	0.06
query9	0.55	0.50	0.48
query10	0.54	0.56	0.55
query11	0.16	0.12	0.12
query12	0.17	0.13	0.14
query13	0.62	0.59	0.59
query14	0.78	0.79	0.78
query15	0.86	0.84	0.82
query16	0.38	0.37	0.38
query17	1.06	1.04	1.04
query18	0.24	0.22	0.23
query19	1.91	1.75	1.82
query20	0.01	0.01	0.01
query21	15.39	0.66	0.66
query22	4.16	6.08	2.31
query23	18.29	1.36	1.24
query24	2.17	0.21	0.22
query25	0.16	0.08	0.07
query26	0.32	0.24	0.24
query27	0.46	0.23	0.24
query28	13.26	1.04	1.02
query29	12.66	3.30	3.29
query30	0.43	0.25	0.24
query31	2.81	0.40	0.41
query32	3.24	0.49	0.50
query33	2.96	3.04	3.06
query34	16.92	4.28	4.39
query35	4.39	4.41	4.40
query36	0.67	0.48	0.48
query37	0.22	0.19	0.18
query38	0.18	0.17	0.17
query39	0.07	0.06	0.05
query40	0.18	0.16	0.15
query41	0.12	0.07	0.06
query42	0.08	0.07	0.07
query43	0.06	0.06	0.06
Total cold run time: 110.22 s
Total hot run time: 31.69 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@924060929 924060929 merged commit 9a06866 into apache:master Aug 20, 2024
dataroaring pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants