[Bug](compatibility) fix agg functions coredump when upgrade #40472

zhangstar333 · 2024-09-06T03:46:39Z

Proposed changes

before use check (IAggregateFunction::version < AGG_FUNCTION_NULLABLE)
and then choose the return type and insert method.

but the version maybe update in the same branch-version，and get wrong type
so put those function to all of object class alone.

doris-robot · 2024-09-06T03:46:44Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

zhangstar333 · 2024-09-06T03:46:57Z

run buildall

github-actions · 2024-09-06T03:53:30Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-09-06T05:18:00Z

TeamCity be ut coverage result:
Function Coverage: 36.87% (9382/25449)
Line Coverage: 28.24% (77370/273937)
Region Coverage: 27.64% (39955/144536)
Branch Coverage: 24.27% (20330/83770)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4edd88e6e5f7c983c3d206ac9a8c136f242b89f3_4edd88e6e5f7c983c3d206ac9a8c136f242b89f3/report/index.html

zhangstar333 · 2024-09-06T07:56:40Z

run buildall

github-actions · 2024-09-06T08:01:28Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-09-06T08:22:12Z

TPC-H: Total hot run time: 38241 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 986e3b9d271b5be55b06ca13a2e9ed587390378d, data reload: false

------ Round 1 ----------------------------------
q1	17764	4620	4380	4380
q2	2637	194	192	192
q3	10969	1149	1095	1095
q4	10686	782	733	733
q5	8188	2863	2820	2820
q6	229	143	142	142
q7	984	634	603	603
q8	9391	2064	2034	2034
q9	7091	6530	6526	6526
q10	6992	2228	2218	2218
q11	447	249	251	249
q12	398	232	233	232
q13	18883	3104	3075	3075
q14	276	256	240	240
q15	539	484	483	483
q16	511	428	438	428
q17	970	640	722	640
q18	7393	6906	6959	6906
q19	1389	1041	1062	1041
q20	685	328	332	328
q21	3949	2967	2896	2896
q22	1114	980	1021	980
Total cold run time: 111485 ms
Total hot run time: 38241 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4376	4320	4266	4266
q2	389	279	269	269
q3	2889	2637	2581	2581
q4	1919	1619	1705	1619
q5	5403	5414	5405	5405
q6	221	135	133	133
q7	2139	1757	1705	1705
q8	3209	3373	3362	3362
q9	8432	8442	8417	8417
q10	3464	3244	3186	3186
q11	589	490	499	490
q12	804	620	636	620
q13	10017	3109	3075	3075
q14	306	294	278	278
q15	514	481	485	481
q16	538	466	490	466
q17	1796	1481	1496	1481
q18	7887	7686	7406	7406
q19	1669	1540	1626	1540
q20	2049	1830	1819	1819
q21	5624	5186	5138	5138
q22	1107	1029	1041	1029
Total cold run time: 65341 ms
Total hot run time: 54766 ms

doris-robot · 2024-09-06T08:30:34Z

TeamCity be ut coverage result:
Function Coverage: 36.84% (9381/25466)
Line Coverage: 28.22% (77331/274028)
Region Coverage: 27.63% (39942/144569)
Branch Coverage: 24.26% (20329/83780)
Coverage Report: http://coverage.selectdb-in.cc/coverage/986e3b9d271b5be55b06ca13a2e9ed587390378d_986e3b9d271b5be55b06ca13a2e9ed587390378d/report/index.html

doris-robot · 2024-09-06T08:33:49Z

TPC-DS: Total hot run time: 187333 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 986e3b9d271b5be55b06ca13a2e9ed587390378d, data reload: false

query1	929	375	364	364
query2	6494	1891	1910	1891
query3	6644	214	217	214
query4	29601	23066	23134	23066
query5	4188	495	481	481
query6	261	168	158	158
query7	4580	287	287	287
query8	274	219	234	219
query9	8801	2459	2457	2457
query10	446	284	262	262
query11	17801	15070	15186	15070
query12	156	99	99	99
query13	1634	374	365	365
query14	9007	7098	7093	7093
query15	271	165	187	165
query16	8095	467	453	453
query17	1600	548	542	542
query18	2129	278	276	276
query19	195	145	142	142
query20	117	109	114	109
query21	203	103	99	99
query22	4322	4079	4213	4079
query23	34027	33486	33481	33481
query24	11327	2935	2837	2837
query25	609	388	393	388
query26	1166	152	149	149
query27	2791	277	277	277
query28	7568	2027	2029	2027
query29	833	412	399	399
query30	296	191	149	149
query31	969	738	800	738
query32	106	61	61	61
query33	779	283	278	278
query34	993	471	473	471
query35	830	715	742	715
query36	1068	941	933	933
query37	163	86	85	85
query38	3958	3838	3972	3838
query39	1436	1390	1401	1390
query40	203	116	114	114
query41	45	44	48	44
query42	111	96	95	95
query43	512	459	472	459
query44	1243	753	732	732
query45	196	166	168	166
query46	1108	761	740	740
query47	1908	1782	1832	1782
query48	370	293	292	292
query49	1093	482	440	440
query50	811	419	401	401
query51	7040	6860	6835	6835
query52	104	85	86	85
query53	251	179	179	179
query54	927	452	447	447
query55	78	74	78	74
query56	264	262	260	260
query57	1234	1104	1087	1087
query58	245	225	231	225
query59	2899	2828	2673	2673
query60	296	260	262	260
query61	104	102	126	102
query62	835	663	679	663
query63	229	191	185	185
query64	5280	787	723	723
query65	3227	3118	3109	3109
query66	1368	337	340	337
query67	15625	15371	15228	15228
query68	3434	599	557	557
query69	379	278	268	268
query70	1195	1062	1154	1062
query71	340	290	281	281
query72	6411	4092	3925	3925
query73	735	323	321	321
query74	9127	8908	8827	8827
query75	3359	2731	2691	2691
query76	1956	1024	964	964
query77	481	377	316	316
query78	9596	9196	9005	9005
query79	1027	530	534	530
query80	696	496	496	496
query81	455	234	227	227
query82	237	143	141	141
query83	170	153	151	151
query84	227	80	80	80
query85	702	295	285	285
query86	305	306	310	306
query87	4379	4412	4327	4327
query88	3166	2280	2284	2280
query89	386	278	287	278
query90	1815	194	184	184
query91	128	104	157	104
query92	57	48	51	48
query93	1040	548	537	537
query94	764	291	290	290
query95	352	257	252	252
query96	582	267	264	264
query97	3225	3060	3103	3060
query98	217	208	203	203
query99	1430	1280	1229	1229
Total cold run time: 282646 ms
Total hot run time: 187333 ms

doris-robot · 2024-09-06T08:39:18Z

ClickBench: Total hot run time: 31.72 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 986e3b9d271b5be55b06ca13a2e9ed587390378d, data reload: false

query1	0.04	0.04	0.04
query2	0.09	0.05	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.08
query5	0.49	0.48	0.51
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.49
query10	0.54	0.57	0.54
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.58	0.59
query14	1.40	1.44	1.42
query15	0.85	0.81	0.83
query16	0.35	0.38	0.37
query17	1.02	1.03	1.07
query18	0.22	0.21	0.21
query19	1.95	1.75	1.75
query20	0.01	0.01	0.01
query21	15.39	0.67	0.66
query22	4.43	6.43	2.14
query23	18.33	1.42	1.31
query24	2.12	0.23	0.22
query25	0.15	0.08	0.08
query26	0.26	0.18	0.18
query27	0.08	0.08	0.08
query28	13.23	1.02	0.99
query29	12.62	3.34	3.40
query30	0.24	0.06	0.05
query31	2.89	0.41	0.39
query32	3.27	0.48	0.47
query33	2.95	3.03	2.98
query34	17.06	4.39	4.41
query35	4.43	4.44	4.42
query36	0.66	0.51	0.51
query37	0.20	0.18	0.16
query38	0.16	0.15	0.14
query39	0.05	0.04	0.04
query40	0.16	0.14	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.39 s
Total hot run time: 31.72 s

github-actions · 2024-09-06T09:40:23Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-06T09:40:25Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

…40472) ## Proposed changes before use check (IAggregateFunction::version < AGG_FUNCTION_NULLABLE) and then choose the return type and insert method. but the version maybe update in the same branch-version，and get wrong type so put those function to all of object class alone.

)(#40472) (#40692) ## Proposed changes cherry-pick from master #40438 #40472

test agg return type

4edd88e

update

986e3b9

zhangstar333 changed the title ~~[test](test)test agg return type~~ [Bug](compatibility) fix agg functions coredump when upgrade Sep 6, 2024

BiteTheDDDDt approved these changes Sep 6, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2024

github-actions bot added the reviewed label Sep 6, 2024

yiguolei added the dev/2.1.x label Sep 6, 2024

dataroaring added the dev/3.0.x label Sep 8, 2024

dataroaring approved these changes Sep 8, 2024

View reviewed changes

dataroaring merged commit ca38271 into apache:master Sep 8, 2024

zhangstar333 mentioned this pull request Sep 11, 2024

[cherry-pick](branch-30) fix agg functions coredump when upgrade (#40438)(#40472) #40692

Merged

zhangstar333 added a commit that referenced this pull request Sep 12, 2024

[cherry-pick](branch-30) fix agg functions coredump when upgrade (#40438

62d5022

)(#40472) (#40692) ## Proposed changes cherry-pick from master #40438 #40472

zhangstar333 added the dev/3.0.2-merged label Sep 12, 2024

zhangstar333 removed the dev/2.1.x label Sep 26, 2024

dataroaring removed the dev/3.0.x label Oct 13, 2024

[Bug](compatibility) fix agg functions coredump when upgrade #40472

[Bug](compatibility) fix agg functions coredump when upgrade #40472

Uh oh!

Conversation

zhangstar333 commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

zhangstar333 commented Sep 6, 2024

Uh oh!

github-actions bot commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

zhangstar333 commented Sep 6, 2024

Uh oh!

github-actions bot commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

github-actions bot commented Sep 6, 2024

Uh oh!

github-actions bot commented Sep 6, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhangstar333 commented Sep 6, 2024 •

edited

Loading