[cherry-pick](branch-30) fix agg functions coredump when upgrade (#40438)(#40472) #40692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#40438) ## Proposed changes ``` if (IAggregateFunction::version < AGG_FUNCTION_NULLABLE) { return make_nullable(Data::get_return_type()); } else { return Data::get_return_type(); } ``` before check two version , and then get return type, but now in branch-21, the IAggregateFunction::version have update to 5, and also AGG_FUNCTION_NEW=5 so the check will not get right return type. <!--Describe your changes.-->
…40472) ## Proposed changes before use check (IAggregateFunction::version < AGG_FUNCTION_NULLABLE) and then choose the return type and insert method. but the version maybe update in the same branch-version，and get wrong type so put those function to all of object class alone.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
cherry-pick from master #40438 #40472