Skip to content

[Feature][Meta]Update/Read/Write VisibleVersionTime for Partition#4076 #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Jul 26, 2020
Merged

[Feature][Meta]Update/Read/Write VisibleVersionTime for Partition#4076 #4086

morningman merged 2 commits into from
Jul 26, 2020

Conversation

@marising
Copy link
Contributor

@marising marising commented Jul 13, 2020

#4076

  1. The visibleVersionTime is updated when insert data to partition
  2. GlobalTransactionMgr call partition.updateVisibleVersionAndVersionHash(version, versionHash) when fe is restarted
  3. If fe restart, VisibleVersionTime may be changed, but the changed value is newer than the old value

morningman
morningman requested changes Jul 15, 2020
View reviewed changes
@morningman morningman self-assigned this Jul 15, 2020
@morningman morningman added area/catalog Issues or PRs related to catalog management kind/meta-version-change Categorizes issue or PR as related to changing meta version labels Jul 15, 2020
morningman
morningman previously approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

morningman commented Jul 22, 2020

Hi @marising the FE code structure has been changed, please rebase the code the solve the conflicts.

@marising marising force-pushed the partition_visibleversiontime branch from 6f1f1ea to 6bc385f Compare July 23, 2020 06:36
morningman
morningman approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jul 25, 2020
@morningman morningman merged commit ed8cb6a into apache:master Jul 26, 2020
This was referenced Jul 29, 2020
Closed
Merged
morningman pushed a commit that referenced this pull request Jul 30, 2020
@caiconghui
[Bug] Fix fe meta version problem, make drop meta check code easy to …
237271c 
…read and add doc content for drop meta check (#4205)

This PR is mainly do three things:
1. Fix fe meta version bug introduced by #4029 , when fix conflict with #4086 
2. Make drop check code easy to read
3. Add doc content for drop meta check
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 21, 2025
@Yukang-Lian
[Enhancement](Compaction) Make base compaction use the same tablet se…
1a906b8 
…lection strategy as cumulative compaction apache#51649 (apache#4086)

Pick doris apache#51649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/meta-version-change Categorizes issue or PR as related to changing meta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marising @morningman