Skip to content

Conversation

@caiconghui
Copy link
Contributor

@caiconghui caiconghui commented Jul 29, 2020

Proposed changes

This PR is mainly do three things:

  1. Fix fe meta version bug introduced by Support check committed txns before catalog drop meta, like db, table, partition etc #4029 , when fix conflict with [Feature][Meta]Update/Read/Write VisibleVersionTime for Partition#4076 #4086
  2. Make drop check code easy to read
  3. Add doc content for drop meta check

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiconghui caiconghui changed the title [Bug] Fix Fe meta problem, make drop meta check code easy to read and add doc content for drop meta check [Bug] Fix Fe meta version problem, make drop meta check code easy to read and add doc content for drop meta check Jul 29, 2020
@caiconghui caiconghui changed the title [Bug] Fix Fe meta version problem, make drop meta check code easy to read and add doc content for drop meta check [Bug] Fix fe meta version problem, make drop meta check code easy to read and add doc content for drop meta check Jul 29, 2020
@morningman morningman self-assigned this Jul 29, 2020
@morningman morningman added area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug. labels Jul 29, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jul 29, 2020
@morningman morningman merged commit 237271c into apache:master Jul 30, 2020
@caiconghui caiconghui deleted the drop_check_bug_fix branch July 30, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants