Skip to content

[fix](FoldConst)The length function returns incorrect results under FoldConst. #40947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BiteTheDDDDt merged 1 commit into from
Oct 9, 2024
Merged

[fix](FoldConst)The length function returns incorrect results under FoldConst. #40947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ava/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public static Expression substringVarcharIntInt(StringLikeLiteral first,
*/
@ExecFunction(name = "length")
public static Expression lengthVarchar(StringLikeLiteral first) {
return new IntegerLiteral(first.getValue().length());
return new IntegerLiteral(first.getValue().getBytes(StandardCharsets.UTF_8).length);
}

/**
Expand Down
1 change: 1 addition & 0 deletions ...on-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ suite("fold_constant_string_arithmatic") {
testFoldConst("SELECT Concat_Ws('-', '2024', '09', '02')")
testFoldConst("SELECT Char(65)")
testFoldConst("SELECT Character_Length('Hello World')")
testFoldConst("SELECT Length('你')")
testFoldConst("SELECT Initcap('hello world')")
testFoldConst("SELECT Md5('Hello World')")
testFoldConst("SELECT Md5Sum('Hello World')")
Expand Down
Loading