[fix](FoldConst)The length function returns incorrect results under FoldConst. #40947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41869 ms |
TPC-DS: Total hot run time: 198926 ms |
ClickBench: Total hot run time: 32.64 s |
Contributor
Author
|
run cloud_p0 |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41082 ms |
TPC-DS: Total hot run time: 191035 ms |
ClickBench: Total hot run time: 32.77 s |
Contributor
Author
|
run external |
zhangstar333
approved these changes
Sep 29, 2024
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Oct 10, 2024
…oldConst. (apache#40947) ## Proposed changes ``` mysql [(none)]>set debug_skip_fold_constant = false; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 1 | +---------------+ 1 row in set (0.01 sec) mysql [(none)]>set debug_skip_fold_constant = true; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 3 | +---------------+ ``` <!--Describe your changes.-->
cjj2010
pushed a commit
to cjj2010/doris
that referenced
this pull request
Oct 12, 2024
…oldConst. (apache#40947) ## Proposed changes ``` mysql [(none)]>set debug_skip_fold_constant = false; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 1 | +---------------+ 1 row in set (0.01 sec) mysql [(none)]>set debug_skip_fold_constant = true; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 3 | +---------------+ ``` <!--Describe your changes.-->
amorynan
pushed a commit
to amorynan/doris
that referenced
this pull request
Oct 12, 2024
…oldConst. (apache#40947) ## Proposed changes ``` mysql [(none)]>set debug_skip_fold_constant = false; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 1 | +---------------+ 1 row in set (0.01 sec) mysql [(none)]>set debug_skip_fold_constant = true; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 3 | +---------------+ ``` <!--Describe your changes.-->
LiBinfeng-01
pushed a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 9, 2025
…oldConst. (apache#40947) ``` mysql [(none)]>set debug_skip_fold_constant = false; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 1 | +---------------+ 1 row in set (0.01 sec) mysql [(none)]>set debug_skip_fold_constant = true; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 3 | +---------------+ ``` <!--Describe your changes.-->
LiBinfeng-01
pushed a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 9, 2025
…oldConst. (apache#40947) ``` mysql [(none)]>set debug_skip_fold_constant = false; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 1 | +---------------+ 1 row in set (0.01 sec) mysql [(none)]>set debug_skip_fold_constant = true; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 3 | +---------------+ ``` <!--Describe your changes.-->
morrySnow
added
dev/2.1.8-merged
dev/2.1.x
dev/3.0.4-merged
and removed
dev/2.1.x
dev/2.1.8-merged
labels
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
…oldConst. (#40947) ## Proposed changes ``` mysql [(none)]>set debug_skip_fold_constant = false; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 1 | +---------------+ 1 row in set (0.01 sec) mysql [(none)]>set debug_skip_fold_constant = true; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 3 | +---------------+ ``` <!--Describe your changes.-->
Contributor
|
already picked into 2.1 by #46523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes