[fix](Nereids) fix fe folding constant of string functions and add more cases (#45233) #46523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re cases (apache#45233) Issue Number: apache#44666 Related PR: apache#40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
apache#40820) example: select append_trailing_char_if_absent('it','a') would return null in original design, it can not return null when folding constant on fe any time
…oldConst. (apache#40947) ``` mysql [(none)]>set debug_skip_fold_constant = false; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 1 | +---------------+ 1 row in set (0.01 sec) mysql [(none)]>set debug_skip_fold_constant = true; Query OK, 0 rows affected (0.00 sec) mysql [(none)]>select length('你'); +---------------+ | length('你') | +---------------+ | 3 | +---------------+ ``` <!--Describe your changes.-->
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Sep 26, 2025
…e cases apache#45233 (apache#46523) pick: apache#45233 Issue Number: apache#44666 Related PR: apache#40441 Problem Summary: select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list reorganize fold constant of string functions in fe and add more cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick: #45233
Issue Number: #44666
Related PR: #40441
Problem Summary:
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)