[fix](cloud) fix double free when get_error_log_file_path #41320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Sep 26, 2024
|
TeamCity be ut coverage result: |
dataroaring
pushed a commit
that referenced
this pull request
Sep 26, 2024
After #40924, `get_error_log_file_path` might be accessed concurrently, leading to error_log_file being closed multiple times. Therefore, a lock was added to solve this issue.
cjj2010
pushed a commit
to cjj2010/doris
that referenced
this pull request
Oct 12, 2024
After apache#40924, `get_error_log_file_path` might be accessed concurrently, leading to error_log_file being closed multiple times. Therefore, a lock was added to solve this issue.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #40924,
get_error_log_file_pathmight be accessed concurrently, leading to error_log_file being closed multiple times. Therefore, a lock was added to solve this issue.