Skip to content

[fix](cloud) fix double free when get_error_log_file_path #41320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liaoxin01 merged 1 commit into from
Sep 26, 2024
Merged

[fix](cloud) fix double free when get_error_log_file_path #41320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions be/src/runtime/runtime_state.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ Status RuntimeState::append_error_msg_to_file(std::function<std::string()> line,
}

std::string RuntimeState::get_error_log_file_path() {
std::lock_guard<std::mutex> l(_s3_error_log_file_lock);
if (_s3_error_fs && _error_log_file && _error_log_file->is_open()) {
// close error log file
_error_log_file->close();
Expand Down
1 change: 1 addition & 0 deletions be/src/runtime/runtime_state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,7 @@ class RuntimeState {
std::shared_ptr<io::S3FileSystem> _s3_error_fs;
// error file path on s3, ${bucket}/${prefix}/error_log/${label}_${fragment_instance_id}
std::string _s3_error_log_file_path;
std::mutex _s3_error_log_file_lock;
};

#define RETURN_IF_CANCELLED(state) \
Expand Down