[feat](job)Implementing Job in Nereids #41391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
morningman
reviewed
Sep 27, 2024
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateJobCommand.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateJobInfo.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateJobInfo.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateJobInfo.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Member
Author
|
run buildall |
TPC-H: Total hot run time: 40888 ms |
TPC-DS: Total hot run time: 192017 ms |
ClickBench: Total hot run time: 32.76 s |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 40872 ms |
TPC-DS: Total hot run time: 191587 ms |
ClickBench: Total hot run time: 33.02 s |
CalvinKirs
force-pushed
the
master-new-job
branch
from
8ddd998 to
2f13bb9
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 40702 ms |
TPC-DS: Total hot run time: 192290 ms |
ClickBench: Total hot run time: 33.36 s |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 40382 ms |
TPC-DS: Total hot run time: 192027 ms |
Member
Author
|
run performance |
morrySnow
reviewed
Oct 10, 2024
| | SHOW CREATE MATERIALIZED VIEW mvName=multipartIdentifier #showCreateMTMV | ||
| ; | ||
|
|
||
| jobScheduleStatement |
Contributor
There was a problem hiding this comment.
Suggested change
| jobScheduleStatement | |
| supportedJobStatement |
| long base = TimeUnit.MINUTES.toMillis(connectionAgeBase); | ||
| long now = System.currentTimeMillis(); | ||
| long rand = random.nextLong(base); | ||
| long rand = random.nextLong() % base; |
Contributor
There was a problem hiding this comment.
already fixed, please rebase to newest master
| Optional<Long> interval = ctx.timeInterval == null ? Optional.empty() : | ||
| Optional.of(Long.valueOf(ctx.timeInterval.getText())); | ||
| Optional<String> intervalUnit = ctx.timeUnit == null ? Optional.empty() : Optional.of(ctx.timeUnit.getText()); | ||
| String commentSpec = ctx.commentSpec() == null ? "''" : ctx.commentSpec().STRING_LITERAL().getText(); |
Contributor
There was a problem hiding this comment.
could u have add override visitCommentSpec, let it return processed comment string?
Comment on lines
+29
to
+31
| sql """ | ||
| SET enable_fallback_to_original_planner=false; | ||
| """ |
Contributor
There was a problem hiding this comment.
this variable has been removed and u do not need to add it
| ; | ||
|
|
||
| jobScheduleStatement | ||
| : CREATE JOB label=multipartIdentifier ON SCHEDULE |
Contributor
There was a problem hiding this comment.
remove create job syntax in sql_parser.cup and remove CreateJobStmt.java
Member
Author
There was a problem hiding this comment.
I want to directly pick to 2.1, as 2.1 allows for a rollback. Therefore, this change will be provided in the next PR.:)
github-actions
bot
removed
the
approved
morrySnow
changed the title
Contributor
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Member
Author
|
run feut |
Member
Author
|
run cloud_p0 |
starocean999
approved these changes
Oct 11, 2024
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Oct 15, 2024
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency.
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Oct 15, 2024
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency. (cherry picked from commit 334b473)
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Oct 17, 2024
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency. (cherry picked from commit 334b473)
yiguolei
pushed a commit
that referenced
this pull request
Oct 17, 2024
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency. (cherry picked from commit 334b473) #41391
morningman
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency.