-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](job)Implementing Job in Nereids #41391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2f13bb9
[feat](job)Implementing Job using antlr4
CalvinKirs be25a1f
fix test
CalvinKirs b195bd7
When a task cacel fails, the exception should be explicitly thrown
CalvinKirs 20e6f03
Merge branch 'master' into master-new-job
CalvinKirs ef45c6b
minor change
CalvinKirs 0e68131
minor change
CalvinKirs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateJobCommand.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.commands; | ||
|
|
||
| import org.apache.doris.analysis.StmtType; | ||
| import org.apache.doris.catalog.Env; | ||
| import org.apache.doris.job.base.AbstractJob; | ||
| import org.apache.doris.nereids.trees.plans.PlanType; | ||
| import org.apache.doris.nereids.trees.plans.commands.info.CreateJobInfo; | ||
| import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; | ||
| import org.apache.doris.qe.ConnectContext; | ||
| import org.apache.doris.qe.StmtExecutor; | ||
|
|
||
| /** | ||
CalvinKirs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * syntax: | ||
| * CREATE | ||
| * [DEFINER = user] | ||
| * JOB | ||
| * event_name | ||
| * ON SCHEDULE schedule | ||
| * [COMMENT 'string'] | ||
| * DO event_body; | ||
| * schedule: { | ||
| * [STREAMING] AT timestamp | ||
| * | EVERY interval | ||
| * [STARTS timestamp ] | ||
| * [ENDS timestamp ] | ||
| * } | ||
| * interval: | ||
| * quantity { DAY | HOUR | MINUTE | | ||
| * WEEK | SECOND } | ||
| */ | ||
| public class CreateJobCommand extends Command implements ForwardWithSync { | ||
|
|
||
| private CreateJobInfo createJobInfo; | ||
|
|
||
| public CreateJobCommand(CreateJobInfo jobInfo) { | ||
| super(PlanType.CREATE_JOB_COMMAND); | ||
| this.createJobInfo = jobInfo; | ||
| } | ||
|
|
||
| @Override | ||
| public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| AbstractJob job = createJobInfo.analyzeAndBuildJobInfo(ctx); | ||
| Env.getCurrentEnv().getJobManager().registerJob(job); | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
| return visitor.visitCreateJobCommand(this, context); | ||
| } | ||
|
|
||
| @Override | ||
| public StmtType stmtType() { | ||
| return StmtType.CREATE; | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove create job syntax in
sql_parser.cupand removeCreateJobStmt.javaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to directly pick to 2.1, as 2.1 allows for a rollback. Therefore, this change will be provided in the next PR.:)