[Bug][TabletRepair] Fix bug that too many replicas generated when decommission BE #4148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/fix
Contributor
Author
|
Rebase to solve the conflict. |
morningman
added
approved
Contributor
Author
|
Sorry that this solution still has problem, I will fix it in this PR after testing in our product env. |
…ommission BE Try to select the BE with an existing replicas as the destination BE for REPLICA_RELOCATING clone task.
morningman
commented
Jul 29, 2020
| // 1. PUSH finished in BE but failed or not yet report to FE | ||
| // 2. repair for VERSION_INCOMPLETE finished in BE, but failed or not yet report to FE | ||
| replica.updateVersionInfo(backendVersion, backendVersionHash, dataSize, rowCount); | ||
| replica.setBad(false); |
Contributor
Author
There was a problem hiding this comment.
For reviewer:
In the original design logic, when the status of a replica is bad, it cannot become not bad again.
This is a clerical error and will cause the admin set replica status function to fail.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jul 30, 2020
…ommission BE (apache#4148) Try to select the BE with an existing replicas as the destination BE for REPLICA_RELOCATING clone task. Fix apache#4147 Also add 2 new FE configs `max_clone_task_timeout_sec` and `min_clone_task_timeout_sec` Change-Id: I948a54bacfd5ba9045fdccecfb44b04f0fda75b7
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Jan 20, 2021
…ommission BE (apache#4148) Try to select the BE with an existing replicas as the destination BE for REPLICA_RELOCATING clone task. Fix apache#4147 Also add 2 new FE configs `max_clone_task_timeout_sec` and `min_clone_task_timeout_sec`
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Sep 23, 2025
…counter fdb txn conflict when mow load get ms delete bitmap lock (apache#52360) (apache#4148) pick apache#52360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Try to select the BE with an existing replicas as the destination BE for
REPLICA_RELOCATING clone task.
Fix #4147
Also add 2 new FE configs
max_clone_task_timeout_secandmin_clone_task_timeout_secTypes of changes
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.