Skip to content

[Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn conflict when mow load get ms delete bitmap lock #52360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 27, 2025
Merged

[Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn conflict when mow load get ms delete bitmap lock #52360

dataroaring merged 1 commit into from
Jun 27, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jun 26, 2025 •
edited
Loading

What problem does this PR solve?

Let mow load txn skip MS RPC framework's backoff sleep time and totally let FE control the backoff time to reduce latency long tail.

Test environment: cloud mode, 1 FE, 3 BE(8C 32GB), 5 threads, 120 buckets, 50rows/per load, cumu threads=8

Before

After

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1 bobhan1 changed the title [Opt](cloud-mow) Skip MS RPC retry's backoff when mow load get ms delete bitmap lock [Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn conflict when mow load get ms delete bitmap lock Jun 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 27, 2025

run buildall

zhannngchen
zhannngchen approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 27, 2025

run cloudut

1 similar comment
@zhannngchen
Copy link
Contributor

zhannngchen commented Jun 27, 2025

run cloudut

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 27, 2025

Cloud UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.52% (1171/1402)
Line Coverage 67.45% (20641/30601)
Region Coverage 67.04% (10254/15295)
Branch Coverage 56.34% (5368/9528)

dataroaring
dataroaring approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a0595a4 into apache:master Jun 27, 2025
43 of 44 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
@bobhan1
[Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn c…
c3f328a 
…onflict when mow load get ms delete bitmap lock (#52360)

### What problem does this PR solve?
Let mow load txn skip MS RPC framework's backoff sleep time and totally
let FE control the backoff time to reduce latency long tail.

Test environment: cloud mode, 1 FE, 3 BE(8C 32GB), 5 threads, 120
buckets, 50rows/per load, cumu threads=8
#### Before
|
![](https://github.com/user-attachments/assets/9d3f80d2-e56e-4153-9247-cddb05e68216)
|
![](https://github.com/user-attachments/assets/d5221f07-ffd4-439b-8125-b4f854887973)
|
|-----------------|-----------------|

#### After
|
![](https://github.com/user-attachments/assets/7ff3d899-9828-4a38-bbaf-62abbd9718d2)
|
![](https://github.com/user-attachments/assets/99fdb83e-bf59-4f24-82f0-9c8557463c29)
|
|-----------------|-----------------|
@github-actions github-actions bot mentioned this pull request Jun 27, 2025
Merged
@bobhan1 bobhan1 mentioned this pull request Jun 27, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jun 27, 2025
@bobhan1
branch-3.0: [Opt](cloud-mow) Skip MS RPC retry's backoff when encount…
0875dbb 
…er fdb txn conflict when mow load get ms delete bitmap lock #52360 (#52439)

pick #52360
morrySnow pushed a commit that referenced this pull request Jun 30, 2025
@github-actions @bobhan1
branch-3.1: [Opt](cloud-mow) Skip MS RPC retry's backoff when encount…
795c994 
…er fdb txn conflict when mow load get ms delete bitmap lock #52360 (#52437)

Cherry-picked from #52360

Co-authored-by: bobhan1 <baohan@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@bobhan1 @koarz
branch-3.0: [Opt](cloud-mow) Skip MS RPC retry's backoff when encount…
065dcc0 
…er fdb txn conflict when mow load get ms delete bitmap lock apache#52360 (apache#52439)

pick apache#52360
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@bobhan1 @koarz
[Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn c…
c7e2eb6 
…onflict when mow load get ms delete bitmap lock (apache#52360)

### What problem does this PR solve?
Let mow load txn skip MS RPC framework's backoff sleep time and totally
let FE control the backoff time to reduce latency long tail.

Test environment: cloud mode, 1 FE, 3 BE(8C 32GB), 5 threads, 120
buckets, 50rows/per load, cumu threads=8
#### Before
|
![](https://github.com/user-attachments/assets/9d3f80d2-e56e-4153-9247-cddb05e68216)
|
![](https://github.com/user-attachments/assets/d5221f07-ffd4-439b-8125-b4f854887973)
|
|-----------------|-----------------|

#### After
|
![](https://github.com/user-attachments/assets/7ff3d899-9828-4a38-bbaf-62abbd9718d2)
|
![](https://github.com/user-attachments/assets/99fdb83e-bf59-4f24-82f0-9c8557463c29)
|
|-----------------|-----------------|
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@bobhan1 @koarz
[Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn c…
31038bf 
…onflict when mow load get ms delete bitmap lock (apache#52360)

### What problem does this PR solve?
Let mow load txn skip MS RPC framework's backoff sleep time and totally
let FE control the backoff time to reduce latency long tail.

Test environment: cloud mode, 1 FE, 3 BE(8C 32GB), 5 threads, 120
buckets, 50rows/per load, cumu threads=8
#### Before
|
![](https://github.com/user-attachments/assets/9d3f80d2-e56e-4153-9247-cddb05e68216)
|
![](https://github.com/user-attachments/assets/d5221f07-ffd4-439b-8125-b4f854887973)
|
|-----------------|-----------------|

#### After
|
![](https://github.com/user-attachments/assets/7ff3d899-9828-4a38-bbaf-62abbd9718d2)
|
![](https://github.com/user-attachments/assets/99fdb83e-bf59-4f24-82f0-9c8557463c29)
|
|-----------------|-----------------|
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@bobhan1 @koarz
[Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn c…
60dace4 
…onflict when mow load get ms delete bitmap lock (apache#52360)

### What problem does this PR solve?
Let mow load txn skip MS RPC framework's backoff sleep time and totally
let FE control the backoff time to reduce latency long tail.

Test environment: cloud mode, 1 FE, 3 BE(8C 32GB), 5 threads, 120
buckets, 50rows/per load, cumu threads=8
#### Before
|
![](https://github.com/user-attachments/assets/9d3f80d2-e56e-4153-9247-cddb05e68216)
|
![](https://github.com/user-attachments/assets/d5221f07-ffd4-439b-8125-b4f854887973)
|
|-----------------|-----------------|

#### After
|
![](https://github.com/user-attachments/assets/7ff3d899-9828-4a38-bbaf-62abbd9718d2)
|
![](https://github.com/user-attachments/assets/99fdb83e-bf59-4f24-82f0-9c8557463c29)
|
|-----------------|-----------------|
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
@bobhan1
(hubspot 4.0.5): [Opt](cloud-mow) Skip MS RPC retry's backoff when en…
9582b5b 
…counter fdb txn conflict when mow load get ms delete bitmap lock (apache#52360) (apache#4148)

pick apache#52360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w41ter w41ter w41ter approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bobhan1 @hello-stephen @zhannngchen @w41ter @dataroaring @morrySnow