Skip to content

branch-3.1: [Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn conflict when mow load get ms delete bitmap lock #52360 #52437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jun 30, 2025
Merged

branch-3.1: [Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn conflict when mow load get ms delete bitmap lock #52360 #52437

morrySnow merged 1 commit into from
Jun 30, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 27, 2025

Cherry-picked from #52360

@bobhan1
[Opt](cloud-mow) Skip MS RPC retry's backoff when encounter fdb txn c…
c3f328a 
…onflict when mow load get ms delete bitmap lock (#52360)

### What problem does this PR solve?
Let mow load txn skip MS RPC framework's backoff sleep time and totally
let FE control the backoff time to reduce latency long tail.

Test environment: cloud mode, 1 FE, 3 BE(8C 32GB), 5 threads, 120
buckets, 50rows/per load, cumu threads=8
#### Before
|
![](https://github.com/user-attachments/assets/9d3f80d2-e56e-4153-9247-cddb05e68216)
|
![](https://github.com/user-attachments/assets/d5221f07-ffd4-439b-8125-b4f854887973)
|
|-----------------|-----------------|

#### After
|
![](https://github.com/user-attachments/assets/7ff3d899-9828-4a38-bbaf-62abbd9718d2)
|
![](https://github.com/user-attachments/assets/99fdb83e-bf59-4f24-82f0-9c8557463c29)
|
|-----------------|-----------------|
@github-actions github-actions bot requested a review from morrySnow as a code owner June 27, 2025 08:51
@Thearas
Copy link
Contributor

Thearas commented Jun 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 27, 2025
@Thearas
Copy link
Contributor

Thearas commented Jun 27, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 27, 2025

Cloud UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.46% (1130/1354)
Line Coverage 67.27% (19660/29225)
Region Coverage 67.29% (9985/14839)
Branch Coverage 56.95% (5276/9264)

@morrySnow morrySnow merged commit 795c994 into branch-3.1 Jun 30, 2025
23 checks passed
@github-actions github-actions bot deleted the auto-pick-52360-branch-3.1 branch June 30, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @hello-stephen @morrySnow @dataroaring @bobhan1