[Fix](Nereids) ignore match expression logging warning message #41546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
LiBinfeng-01
force-pushed
the
fix_match_fold_const_be
branch
from
bc547fc to
fcc0921
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
starocean999
previously approved these changes
Oct 10, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
reviewed
Oct 10, 2024
| } catch (Exception e) { | ||
| LOG.warn("expression {} translate to legacy expr failed. ", expr, e); | ||
| // match expression need to contain slotReference so it can not be folded pr:#39652 | ||
| if (!(expr.containsType(Match.class))) { |
Contributor
There was a problem hiding this comment.
i think we should not do tranlate match at all? so we should add match into shouldSkipFold? because we need to fold its children
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
morrySnow
reviewed
Oct 11, 2024
| // This kind of function is often used to change the attributes of columns. | ||
| // Folding will make it impossible to construct columns such as nullable(1). | ||
| if (expr instanceof Nullable || expr instanceof NonNullable) { | ||
| if (expr.containsType(Nullable.class) || expr.containsType(NonNullable.class)) { |
Contributor
There was a problem hiding this comment.
this will traverse expr tree too many times, could we only traverse once by expr.anyMatch(e -> shouldSkipFold(e)) ?
LiBinfeng-01
force-pushed
the
fix_match_fold_const_be
branch
from
3c1ecaa to
c1c12e9
Compare
Contributor
Author
|
run buildall |
morrySnow
previously approved these changes
Oct 11, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
morrySnow
approved these changes
Oct 15, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
starocean999
approved these changes
Oct 15, 2024
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 17, 2024
…e#41546) when match do not contains slot reference it would throw an exception when translate to original planner expr. this kind of message is not need to be recorded
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 17, 2024
…e#41546) when match do not contains slot reference it would throw an exception when translate to original planner expr. this kind of message is not need to be recorded
924060929
pushed a commit
that referenced
this pull request
Oct 18, 2024
…#41164)(#41331)(#41546) (#41838) cherry-pick: #39723 #41164 #41331 #41546 because later problem is intro by prev one, so put them together when using fold constant by be, the return type of substring('123456',1, 3) would changed to be text, which we want it to be 3 remove windowframe in window expression to avoid folding constant on be
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 21, 2024
…e#41546) when match do not contains slot reference it would throw an exception when translate to original planner expr. this kind of message is not need to be recorded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when match do not contains slot reference it would throw an exception when translate to original planner expr.
this kind of message is not need to be recorded