Skip to content

[chore](plugin)It's allowed for the plugin directory to be empty when loading plugins #41574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CalvinKirs merged 1 commit into from
Oct 9, 2024
Merged

[chore](plugin)It's allowed for the plugin directory to be empty when loading plugins #41574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/common/util/ClassLoaderUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import org.apache.doris.mysql.privilege.AccessControllerFactory;

import org.apache.commons.collections.map.HashedMap;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -57,6 +59,7 @@
* @see ChildFirstClassLoader
*/
public class ClassLoaderUtils {
private static final Logger LOG = LogManager.getLogger(ClassLoaderUtils.class);
// A mapping of service class simple names to their respective plugin directories.
private static final Map<String, String> pluginDirMapping = new HashedMap();

Expand Down Expand Up @@ -99,7 +102,8 @@ public static <T> List<T> loadServicesFromDirectory(Class<T> serviceClass) throw

File[] jarFiles = jarDir.listFiles((dir, name) -> name.endsWith(".jar"));
if (jarFiles == null || jarFiles.length == 0) {
throw new IOException("No JAR files found in the specified directory: " + pluginDir);
LOG.info("No JAR files found in the plugin directory: {}", pluginDir);
return new ArrayList<>();
}

List<T> services = new ArrayList<>();
Expand Down