[chore](plugin)It's allowed for the plugin directory to be empty when loading plugins #41574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's allowed for the plugin directory to be empty when loading plugins When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
zy-kkk
approved these changes
Oct 9, 2024
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Oct 10, 2024
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
cjj2010
pushed a commit
to cjj2010/doris
that referenced
this pull request
Oct 12, 2024
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
amorynan
pushed a commit
to amorynan/doris
that referenced
this pull request
Oct 12, 2024
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
bobhan1
pushed a commit
to bobhan1/doris
that referenced
this pull request
Nov 14, 2024
… loading plugins (apache#41574) (apache#209) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this. (cherry picked from commit 9b25a83)
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jul 1, 2025
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this. (cherry picked from commit 9b25a83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
in #41100 An exception will be thrown if the user creates the plugin directory but it is empty.
When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.