Skip to content

branch-3.1: [feat](Authorization-plugin)Authorization framework modularization (#40750 #41100 #41574) #52577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 4 commits into from
Jul 2, 2025
Merged

branch-3.1: [feat](Authorization-plugin)Authorization framework modularization (#40750 #41100 #41574) #52577

morrySnow merged 4 commits into from
Jul 2, 2025

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Jul 1, 2025 •
edited
Loading

CalvinKirs and others added 3 commits July 1, 2025 14:22
@CalvinKirs
branch-3.1: [feat](Authorization-plugin)Authorization framework modul…
f928adc 
…arization (apache#40750)

apache#40750
(cherry picked from commit dd5605e)
@CalvinKirs
[Feat](Authentication)Supporting Authentication Plugins and Kernel Is…
9d9ea9c 
…olation (apache#41100)

## Proposed changes
- Use a Child-First ClassLoader to isolate plugins from the kernel,
giving priority to plugin classes to prevent conflicts between the
plugin and kernel classes.
- Allow users to place plugins in a specified directory, such as
auth-lib, to avoid classpath conflicts by default.
- Support developers in debugging plugins by allowing them to bring in
plugins via Maven, making the debugging process more convenient.

(cherry picked from commit c34e86b)
@CalvinKirs
[chore](plugin)It's allowed for the plugin directory to be empty when…
5f1d4e3 
… loading plugins (apache#41574)

## Proposed changes
in apache#41100 An exception will be thrown if the user creates the plugin
directory but it is empty.
When loading plugins, it's acceptable for the plugin directory to be
empty. Users might create the directory without placing any plugins
inside, but since some plugins are still located on the classpath, this
doesn’t cause any issues. If users specify a particular plugin but don’t
place it in the directory, the business logic should handle that
situation. The general-purpose class shouldn’t be concerned with this.

(cherry picked from commit 9b25a83)
@CalvinKirs CalvinKirs requested a review from morrySnow as a code owner July 1, 2025 06:33
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs CalvinKirs changed the title branch-3.1: [feat](Authorization-plugin)Authorization framework modularization (#40750 #41100) branch-3.1: [feat](Authorization-plugin)Authorization framework modularization (#40750 #41100 #41574) Jul 1, 2025
@CalvinKirs
Copy link
Member Author

CalvinKirs commented Jul 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

TPC-H: Total hot run time: 39876 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 51c1439d8afd9eda91b09e9c1772489d6f5c3d7b, data reload: false

------ Round 1 ----------------------------------
q1	17936	6941	6620	6620
q2	2095	168	166	166
q3	10640	1148	1137	1137
q4	10509	749	713	713
q5	8109	2866	2897	2866
q6	220	135	136	135
q7	993	619	621	619
q8	9357	1951	2025	1951
q9	6668	6396	6442	6396
q10	7002	2297	2308	2297
q11	450	256	272	256
q12	401	219	212	212
q13	17786	3004	2996	2996
q14	261	215	212	212
q15	509	464	478	464
q16	448	383	384	383
q17	972	625	587	587
q18	7461	6639	6778	6639
q19	1356	954	1001	954
q20	505	207	204	204
q21	4398	3100	3213	3100
q22	1070	969	993	969
Total cold run time: 109146 ms
Total hot run time: 39876 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6777	6605	6583	6583
q2	324	235	227	227
q3	3028	2933	2954	2933
q4	2069	1777	1749	1749
q5	5708	5710	5760	5710
q6	216	133	131	131
q7	2259	1853	1818	1818
q8	3357	3534	3511	3511
q9	8744	8813	8847	8813
q10	3591	3539	3533	3533
q11	580	502	490	490
q12	848	606	618	606
q13	7381	3196	3203	3196
q14	308	274	270	270
q15	517	476	475	475
q16	498	451	451	451
q17	1845	1620	1604	1604
q18	8394	7755	7781	7755
q19	1679	1562	1550	1550
q20	2046	1875	1906	1875
q21	5194	5075	5087	5075
q22	1114	1053	1018	1018
Total cold run time: 66477 ms
Total hot run time: 59373 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

TPC-DS: Total hot run time: 197201 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 51c1439d8afd9eda91b09e9c1772489d6f5c3d7b, data reload: false

query1	1310	930	909	909
query2	6262	1992	1907	1907
query3	10879	4317	4365	4317
query4	33253	23558	23486	23486
query5	3615	480	449	449
query6	255	172	174	172
query7	3999	316	321	316
query8	294	234	235	234
query9	9619	2603	2597	2597
query10	491	271	262	262
query11	17920	15167	15209	15167
query12	154	101	105	101
query13	1564	436	418	418
query14	9184	6687	6817	6687
query15	240	186	182	182
query16	7823	497	479	479
query17	1653	629	610	610
query18	2091	349	327	327
query19	218	171	178	171
query20	130	119	118	118
query21	207	117	113	113
query22	4804	4447	4609	4447
query23	34945	34285	34485	34285
query24	11522	2970	2982	2970
query25	668	433	457	433
query26	759	188	194	188
query27	2213	377	362	362
query28	6455	2210	2196	2196
query29	851	471	475	471
query30	281	159	161	159
query31	1063	844	805	805
query32	91	59	58	58
query33	767	316	303	303
query34	947	520	529	520
query35	865	759	734	734
query36	1124	939	979	939
query37	115	71	66	66
query38	4073	4079	3916	3916
query39	1515	1457	1461	1457
query40	199	107	108	107
query41	56	51	46	46
query42	114	105	104	104
query43	538	499	500	499
query44	1284	851	833	833
query45	192	175	179	175
query46	1197	774	752	752
query47	1993	1855	1964	1855
query48	458	358	348	348
query49	923	422	409	409
query50	871	445	433	433
query51	7493	7318	7117	7117
query52	104	91	90	90
query53	276	193	191	191
query54	1238	483	488	483
query55	79	88	82	82
query56	269	248	252	248
query57	1298	1207	1194	1194
query58	228	218	216	216
query59	3233	3148	3106	3106
query60	294	274	282	274
query61	114	130	128	128
query62	871	691	705	691
query63	224	194	194	194
query64	4018	679	628	628
query65	3410	3268	3349	3268
query66	858	324	307	307
query67	16188	15510	15544	15510
query68	4582	596	583	583
query69	459	272	269	269
query70	1210	1138	1124	1124
query71	355	259	269	259
query72	6369	3783	3976	3783
query73	811	360	356	356
query74	10509	8978	9288	8978
query75	3370	2677	2683	2677
query76	2638	1108	1096	1096
query77	422	288	270	270
query78	10465	9799	9688	9688
query79	2555	600	618	600
query80	1194	439	422	422
query81	535	227	222	222
query82	885	93	90	90
query83	240	140	143	140
query84	240	81	82	81
query85	1517	310	294	294
query86	489	305	300	300
query87	4350	4258	4229	4229
query88	4229	2419	2380	2380
query89	422	291	298	291
query90	1941	195	192	192
query91	143	109	106	106
query92	67	54	54	54
query93	2321	572	577	572
query94	790	288	298	288
query95	372	266	277	266
query96	633	287	293	287
query97	3334	3217	3171	3171
query98	212	204	207	204
query99	1554	1313	1310	1310
Total cold run time: 301452 ms
Total hot run time: 197201 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

ClickBench: Total hot run time: 30.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 51c1439d8afd9eda91b09e9c1772489d6f5c3d7b, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.04	0.03
query3	0.24	0.06	0.06
query4	1.65	0.10	0.10
query5	0.50	0.50	0.52
query6	1.13	0.74	0.73
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.56	0.49	0.52
query10	0.56	0.54	0.54
query11	0.15	0.11	0.10
query12	0.15	0.11	0.12
query13	0.61	0.60	0.59
query14	0.78	0.78	0.80
query15	0.85	0.84	0.82
query16	0.39	0.38	0.38
query17	1.01	1.03	1.06
query18	0.24	0.22	0.22
query19	2.01	1.88	1.85
query20	0.01	0.01	0.01
query21	15.39	0.57	0.56
query22	2.26	2.58	2.04
query23	16.89	1.04	0.83
query24	2.65	0.58	1.73
query25	0.28	0.10	0.05
query26	0.46	0.14	0.14
query27	0.04	0.05	0.06
query28	10.53	0.48	0.46
query29	12.59	3.22	3.21
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.24	0.47	0.46
query33	2.94	3.01	3.00
query34	16.62	4.49	4.53
query35	4.63	4.54	4.54
query36	0.63	0.50	0.47
query37	0.08	0.05	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.14
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.75 s
Total hot run time: 30.02 s

@morrySnow morrySnow merged commit b09efdd into apache:branch-3.1 Jul 2, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CalvinKirs @hello-stephen @doris-robot @morrySnow