[Feat](Authentication)Supporting Authentication Plugins and Kernel Isolation #41100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a Child-First ClassLoader to isolate plugins from the kernel, giving priority to plugin classes to prevent conflicts between the plugin and kernel classes. Allow users to place plugins in a specified directory, such as auth-lib, to avoid classpath conflicts by default. Support developers in debugging plugins by allowing them to bring in plugins via Maven, making the debugging process more convenient.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
CalvinKirs
commented
Sep 23, 2024
| private static final Map<String, String> pluginDirMapping = new HashedMap(); | ||
|
|
||
| static { | ||
| pluginDirMapping.put(AuthenticatorFactory.class.getSimpleName(), "auth-lib"); |
Member
Author
There was a problem hiding this comment.
This directory might not be ideal; perhaps we should use plugin/auth instead?
CalvinKirs
force-pushed
the
master-auth-classloader
branch
from
eec5517 to
b6c9474
Compare
Member
Author
|
run buildall |
Member
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
…er-auth-classloader # Conflicts: # fe/fe-common/src/main/java/org/apache/doris/common/Config.java
Member
Author
|
run buildall |
morningman
approved these changes
Sep 25, 2024
JNSimba
approved these changes
Sep 25, 2024
CalvinKirs
added a commit
that referenced
this pull request
Oct 9, 2024
… loading plugins (#41574) ## Proposed changes in #41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Oct 10, 2024
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
cjj2010
pushed a commit
to cjj2010/doris
that referenced
this pull request
Oct 12, 2024
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
amorynan
pushed a commit
to amorynan/doris
that referenced
this pull request
Oct 12, 2024
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this.
bobhan1
pushed a commit
to bobhan1/doris
that referenced
this pull request
Oct 23, 2024
…olation (apache#41100) ## Proposed changes - Use a Child-First ClassLoader to isolate plugins from the kernel, giving priority to plugin classes to prevent conflicts between the plugin and kernel classes. - Allow users to place plugins in a specified directory, such as auth-lib, to avoid classpath conflicts by default. - Support developers in debugging plugins by allowing them to bring in plugins via Maven, making the debugging process more convenient. (cherry picked from commit c34e86b)
bobhan1
pushed a commit
to bobhan1/doris
that referenced
this pull request
Nov 14, 2024
… loading plugins (apache#41574) (apache#209) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this. (cherry picked from commit 9b25a83)
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Nov 21, 2024
…olation (apache#41100) - Use a Child-First ClassLoader to isolate plugins from the kernel, giving priority to plugin classes to prevent conflicts between the plugin and kernel classes. - Allow users to place plugins in a specified directory, such as auth-lib, to avoid classpath conflicts by default. - Support developers in debugging plugins by allowing them to bring in plugins via Maven, making the debugging process more convenient.
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jul 1, 2025
…olation (apache#41100) ## Proposed changes - Use a Child-First ClassLoader to isolate plugins from the kernel, giving priority to plugin classes to prevent conflicts between the plugin and kernel classes. - Allow users to place plugins in a specified directory, such as auth-lib, to avoid classpath conflicts by default. - Support developers in debugging plugins by allowing them to bring in plugins via Maven, making the debugging process more convenient. (cherry picked from commit c34e86b)
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jul 1, 2025
… loading plugins (apache#41574) ## Proposed changes in apache#41100 An exception will be thrown if the user creates the plugin directory but it is empty. When loading plugins, it's acceptable for the plugin directory to be empty. Users might create the directory without placing any plugins inside, but since some plugins are still located on the classpath, this doesn’t cause any issues. If users specify a particular plugin but don’t place it in the directory, the business logic should handle that situation. The general-purpose class shouldn’t be concerned with this. (cherry picked from commit 9b25a83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes