-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](ip-function)improve is_ip_address_in_range for inverted index speed #41768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve](ip-function)improve is_ip_address_in_range for inverted index speed #41768
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
regression-test/suites/inverted_index_p0/test_ip_cidr_search_with_inverted_index.groovy
Show resolved
Hide resolved
zzzxl1993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| String get_name() const override { return name; } | ||
|
|
||
| size_t get_number_of_arguments() const override { return 2; } | ||
| Status evaluate_inverted_index( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'evaluate_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]
Status evaluate_inverted_index(
^Additional context
be/src/vec/functions/function_ip.h:641: 90 lines including whitespace and comments (threshold 80)
Status evaluate_inverted_index(
^|
TeamCity be ut coverage result: |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…ex speed (apache#41768) ## Proposed changes speed up is_ip_address_in_range with inverted index
…ex speed (apache#41768) speed up is_ip_address_in_range with inverted index
…ex speed (apache#41768) speed up is_ip_address_in_range with inverted index
Proposed changes
speed up is_ip_address_in_range with inverted index
Issue Number: close #xxx