Skip to content

Conversation

@amorynan
Copy link
Contributor

Proposed changes

speed up is_ip_address_in_range with inverted index

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.43% (9679/25858)
Line Coverage: 28.67% (80253/279958)
Region Coverage: 28.11% (41527/147735)
Branch Coverage: 24.69% (21112/85504)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e4ee6a1f016145534da19b6b8b40ec38b32f8538_e4ee6a1f016145534da19b6b8b40ec38b32f8538/report/index.html

Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

String get_name() const override { return name; }

size_t get_number_of_arguments() const override { return 2; }
Status evaluate_inverted_index(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'evaluate_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]

    Status evaluate_inverted_index(
           ^
Additional context

be/src/vec/functions/function_ip.h:641: 90 lines including whitespace and comments (threshold 80)

    Status evaluate_inverted_index(
           ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25912)
Line Coverage: 28.73% (80603/280539)
Region Coverage: 28.18% (41708/148020)
Branch Coverage: 24.76% (21212/85678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/75140747133e72cd0aa25f393db4dac0ea9e556d_75140747133e72cd0aa25f393db4dac0ea9e556d/report/index.html

@amorynan amorynan requested a review from airborne12 October 15, 2024 06:52
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@airborne12 airborne12 merged commit 39f4883 into apache:master Oct 16, 2024
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 17, 2024
…ex speed (apache#41768)

## Proposed changes
speed up is_ip_address_in_range with inverted index
eldenmoon pushed a commit that referenced this pull request Oct 17, 2024
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 25, 2024
…ex speed (apache#41768)

speed up is_ip_address_in_range with inverted index
yiguolei pushed a commit to amorynan/doris that referenced this pull request Dec 10, 2024
…ex speed (apache#41768)

speed up is_ip_address_in_range with inverted index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged p0_c reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants