Skip to content

[improve](ip-function)improve is_ip_address_in_range for inverted index speed (#41768) #42485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amorynan wants to merge 3 commits into from
Closed

[improve](ip-function)improve is_ip_address_in_range for inverted index speed (#41768) #42485

amorynan wants to merge 3 commits into from

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Oct 25, 2024 •
edited by xiaokang
Loading

speed up is_ip_address_in_range with inverted index

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

doris-robot commented Oct 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

amorynan commented Oct 25, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_ip.h
}
}

Status evaluate_inverted_index(
Copy link
Contributor

@github-actions github-actions bot Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'evaluate_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]

    Status evaluate_inverted_index(
           ^
Additional context

be/src/vec/functions/function_ip.h:692: 90 lines including whitespace and comments (threshold 80)

    Status evaluate_inverted_index(
           ^

@xiaokang xiaokang changed the title [improve](ip-function)improve is_ip_address_in_range for inverted ind… [improve](ip-function)improve is_ip_address_in_range for inverted index speed (#41768) Oct 30, 2024
@yiguolei
Copy link
Contributor

yiguolei commented Oct 30, 2024

run buildall

1 similar comment
@amorynan
Copy link
Contributor Author

amorynan commented Oct 30, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@amorynan
Copy link
Contributor Author

amorynan commented Oct 31, 2024

run buildall

2 similar comments
@amorynan
Copy link
Contributor Author

amorynan commented Nov 5, 2024

run buildall

@amorynan
Copy link
Contributor Author

amorynan commented Nov 8, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 8, 2024

TeamCity be ut coverage result:
Function Coverage: 36.30% (9460/26062)
Line Coverage: 27.83% (77866/279749)
Region Coverage: 26.50% (39950/150751)
Branch Coverage: 23.28% (20288/87134)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b64e0c5914960ef53f0ba53b6065d103a4027577_b64e0c5914960ef53f0ba53b6065d103a4027577/report/index.html

@amorynan
Copy link
Contributor Author

amorynan commented Nov 8, 2024

run p0

@amorynan
Copy link
Contributor Author

amorynan commented Nov 8, 2024

run external

@yiguolei yiguolei force-pushed the pick_41768_to_doris_branch-2.1 branch from b64e0c5 to cc29b78 Compare December 10, 2024 07:30
@yiguolei
Copy link
Contributor

yiguolei commented Dec 10, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Dec 10, 2024

TeamCity be ut coverage result:
Function Coverage: 36.49% (9563/26210)
Line Coverage: 27.90% (78530/281471)
Region Coverage: 26.58% (40315/151700)
Branch Coverage: 23.33% (20419/87528)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cc29b78cd7770530000d5f34472509211fca2cf0_cc29b78cd7770530000d5f34472509211fca2cf0/report/index.html

@yiguolei yiguolei closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amorynan @doris-robot @yiguolei