Skip to content

[fix](inverted index) Fix incorrect exception handling #41874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 1 commit into from
Oct 16, 2024
Merged

[fix](inverted index) Fix incorrect exception handling #41874

airborne12 merged 1 commit into from
Oct 16, 2024

Conversation

@zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Oct 15, 2024

Proposed changes

  1. Memory leaks may occur in exceptional situations

@doris-robot
Copy link

doris-robot commented Oct 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Oct 15, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/olap/rowset/segment_v2/inverted_index/index_compaction_test.cpp
// specific language governing permissions and limitations
// under the License.

#include <gtest/gtest.h>
Copy link
Contributor

@github-actions github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

@doris-robot
Copy link

doris-robot commented Oct 15, 2024

TeamCity be ut coverage result:
Function Coverage: 37.46% (9709/25916)
Line Coverage: 28.73% (80583/280486)
Region Coverage: 28.19% (41706/147963)
Branch Coverage: 24.76% (21204/85632)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4658cab8d328daca5e57fb9af98f594928c535ef_4658cab8d328daca5e57fb9af98f594928c535ef/report/index.html

airborne12
airborne12 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit e9e90b9 into apache:master Oct 16, 2024
@zzzxl1993 zzzxl1993 mentioned this pull request Oct 18, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 19, 2024
@zzzxl1993
[fix](inverted index) Fix incorrect exception handling (#42094)
d5fef26 
#41874
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Nov 7, 2024
@zzzxl1993
[fix](inverted index) Fix incorrect exception handling (apache#41874)
416b80d 
## Proposed changes

1. Memory leaks may occur in exceptional situations
@zzzxl1993 zzzxl1993 mentioned this pull request Nov 7, 2024
Merged
airborne12 pushed a commit that referenced this pull request Nov 8, 2024
@zzzxl1993
[fix](inverted index) Fix incorrect exception handling (#41874) (#43395)
643ac39 
pick #41874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@airborne12 airborne12 airborne12 approved these changes

@qidaye qidaye qidaye approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zzzxl1993 @doris-robot @airborne12 @qidaye @yiguolei