Skip to content

[fix](inverted index) Fix incorrect exception handling (#41874) #43395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 1 commit into from
Nov 8, 2024
Merged

[fix](inverted index) Fix incorrect exception handling (#41874) #43395

airborne12 merged 1 commit into from
Nov 8, 2024

Conversation

@zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Nov 7, 2024

pick #41874

@zzzxl1993
[fix](inverted index) Fix incorrect exception handling (apache#41874)
416b80d 
## Proposed changes

1. Memory leaks may occur in exceptional situations
@doris-robot
Copy link

doris-robot commented Nov 7, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Nov 7, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/olap/rowset/segment_v2/inverted_index/index_compaction_test.cpp
// specific language governing permissions and limitations
// under the License.

#include <gtest/gtest.h>
Copy link
Contributor

@github-actions github-actions bot Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

@doris-robot
Copy link

doris-robot commented Nov 7, 2024

TPC-H: Total hot run time: 40771 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 416b80d22f34fe606b0e32e63f8f48cba3db1e77, data reload: false

------ Round 1 ----------------------------------
q1	18067	7521	7394	7394
q2	2409	192	162	162
q3	10604	1120	1133	1120
q4	10402	754	682	682
q5	7732	2856	2795	2795
q6	237	145	143	143
q7	958	602	591	591
q8	9364	2021	1968	1968
q9	6626	6373	6440	6373
q10	7009	2286	2293	2286
q11	481	255	260	255
q12	400	209	208	208
q13	17788	2948	2924	2924
q14	247	213	217	213
q15	569	522	518	518
q16	693	600	602	600
q17	991	588	565	565
q18	7328	6628	6496	6496
q19	1816	1076	1088	1076
q20	463	197	201	197
q21	4210	3272	3243	3243
q22	1053	996	962	962
Total cold run time: 109447 ms
Total hot run time: 40771 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7368	7265	7313	7265
q2	399	315	305	305
q3	2857	2708	2698	2698
q4	1955	1636	1687	1636
q5	5378	5445	5442	5442
q6	222	136	138	136
q7	2075	1645	1642	1642
q8	3247	3389	3424	3389
q9	8459	8507	8472	8472
q10	3445	3391	3356	3356
q11	575	485	500	485
q12	760	564	560	560
q13	16897	2980	2926	2926
q14	294	266	272	266
q15	588	524	538	524
q16	683	655	661	655
q17	1811	1571	1553	1553
q18	7583	7436	7303	7303
q19	1654	1651	1612	1612
q20	1967	1760	1774	1760
q21	5186	4994	5064	4994
q22	1084	974	990	974
Total cold run time: 74487 ms
Total hot run time: 57953 ms

@doris-robot
Copy link

doris-robot commented Nov 7, 2024

TPC-DS: Total hot run time: 190967 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 416b80d22f34fe606b0e32e63f8f48cba3db1e77, data reload: false

query1	962	390	377	377
query2	6523	2117	2052	2052
query3	6692	210	237	210
query4	33869	26010	23404	23404
query5	4378	452	440	440
query6	279	195	187	187
query7	4622	312	311	311
query8	301	240	233	233
query9	9489	2727	2691	2691
query10	471	263	260	260
query11	17963	15097	15292	15097
query12	149	104	101	101
query13	1632	434	404	404
query14	9514	7317	6746	6746
query15	246	171	174	171
query16	7359	497	471	471
query17	1624	568	547	547
query18	2233	603	588	588
query19	246	186	177	177
query20	118	107	107	107
query21	212	103	109	103
query22	4415	4263	4353	4263
query23	35247	33659	33709	33659
query24	12782	3364	3375	3364
query25	675	397	408	397
query26	1556	180	198	180
query27	2616	297	295	295
query28	7764	2503	2494	2494
query29	932	450	426	426
query30	451	306	302	302
query31	1044	794	818	794
query32	102	59	59	59
query33	776	297	286	286
query34	967	497	504	497
query35	836	717	699	699
query36	1110	938	912	912
query37	206	75	72	72
query38	3888	3888	3783	3783
query39	1628	1430	1430	1430
query40	290	103	101	101
query41	52	50	51	50
query42	112	107	97	97
query43	537	496	493	493
query44	1318	816	790	790
query45	192	170	169	169
query46	1149	719	727	719
query47	1883	1800	1808	1800
query48	473	376	376	376
query49	1266	398	395	395
query50	803	402	414	402
query51	7063	6974	7051	6974
query52	106	97	94	94
query53	256	189	190	189
query54	1255	454	467	454
query55	74	74	74	74
query56	253	247	240	240
query57	1193	1077	1128	1077
query58	226	201	205	201
query59	3109	2987	3026	2987
query60	272	241	266	241
query61	126	111	120	111
query62	843	666	680	666
query63	209	187	185	185
query64	5585	658	636	636
query65	3237	3170	3180	3170
query66	1221	322	297	297
query67	15922	15581	15294	15294
query68	5567	573	608	573
query69	398	255	250	250
query70	1141	1114	1127	1114
query71	395	255	258	255
query72	6172	3898	4032	3898
query73	755	341	340	340
query74	9329	8975	8941	8941
query75	3364	2626	2584	2584
query76	3416	945	947	945
query77	477	267	275	267
query78	10537	9645	9531	9531
query79	8733	596	591	591
query80	1912	431	416	416
query81	583	238	246	238
query82	1430	125	125	125
query83	276	160	155	155
query84	287	80	82	80
query85	2332	316	292	292
query86	494	296	299	296
query87	4483	4239	4298	4239
query88	5940	2354	2485	2354
query89	562	296	286	286
query90	2282	183	183	183
query91	180	145	146	145
query92	69	48	51	48
query93	6691	552	543	543
query94	1181	287	288	287
query95	354	249	258	249
query96	635	274	273	273
query97	3353	3129	3129	3129
query98	221	196	202	196
query99	2036	1284	1273	1273
Total cold run time: 320487 ms
Total hot run time: 190967 ms

airborne12
airborne12 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit 643ac39 into apache:branch-3.0 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@airborne12 airborne12 airborne12 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zzzxl1993 @doris-robot @airborne12