Skip to content

Conversation

@yujun777
Copy link
Contributor

If users use different LOCAL_DORIS_PATH, their clusters' network maybe conflict. So let different user use different searched start subnet.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777
Copy link
Contributor Author

run buildall

gavinchou
gavinchou previously approved these changes Oct 17, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Oct 17, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yujun777 yujun777 dismissed stale reviews from dataroaring and gavinchou via 021a88a October 17, 2024 02:37
@yujun777 yujun777 force-pushed the docker-compose-use-diff-subnet branch from 255328e to 021a88a Compare October 17, 2024 02:37
@yujun777
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 17, 2024
@yujun777
Copy link
Contributor Author

run p0

@yujun777
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 68c28a0 into apache:master Oct 20, 2024
dataroaring pushed a commit that referenced this pull request Nov 8, 2024
 (#43454)

If users use different LOCAL_DORIS_PATH, their clusters' network maybe
conflict. So let different user use different searched start subnet.

cherry-pick: #41996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants