Skip to content

[Fix] (compile) Missing field initializer and unused const variable #42215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 1 commit into from
Oct 22, 2024
Merged

[Fix] (compile) Missing field initializer and unused const variable #42215

HappenLee merged 1 commit into from
Oct 22, 2024

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Oct 21, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

Earlier, we turned on the -Wno-missing-field-initializers and -Wno-unused-const-variable switches, now choose to disable them

same as #37403

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Oct 21, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

TPC-H: Total hot run time: 41473 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 12f21412445af504a074197c33e844ee3c4fcbc7, data reload: false

------ Round 1 ----------------------------------
q1	17575	7396	7677	7396
q2	2026	297	292	292
q3	12044	1067	1184	1067
q4	10590	886	837	837
q5	7795	3124	3099	3099
q6	235	161	158	158
q7	1037	634	622	622
q8	9376	1927	1992	1927
q9	6645	6454	6392	6392
q10	7108	2432	2433	2432
q11	446	246	248	246
q12	417	221	221	221
q13	17769	2989	3028	2989
q14	241	208	218	208
q15	578	517	523	517
q16	676	582	588	582
q17	967	669	486	486
q18	7377	6651	6665	6651
q19	1360	979	1011	979
q20	504	188	183	183
q21	3966	3203	3237	3203
q22	1090	986	1007	986
Total cold run time: 109822 ms
Total hot run time: 41473 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7255	7216	7225	7216
q2	334	247	228	228
q3	3077	2915	2956	2915
q4	2061	1812	1843	1812
q5	5802	5767	5829	5767
q6	232	144	140	140
q7	2296	1828	1825	1825
q8	3402	3508	3425	3425
q9	9028	9025	8943	8943
q10	3612	3568	3585	3568
q11	588	494	501	494
q12	878	633	625	625
q13	9525	3224	3216	3216
q14	304	267	269	267
q15	583	522	513	513
q16	704	649	658	649
q17	1859	1630	1601	1601
q18	8303	7832	7673	7673
q19	1693	1395	1496	1395
q20	2119	1880	1888	1880
q21	5553	5418	5405	5405
q22	1109	1053	1076	1053
Total cold run time: 70317 ms
Total hot run time: 60610 ms

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

TPC-DS: Total hot run time: 192083 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 12f21412445af504a074197c33e844ee3c4fcbc7, data reload: false

query1	927	401	402	401
query2	6250	2190	2094	2094
query3	8686	197	201	197
query4	34402	23683	24141	23683
query5	3989	470	478	470
query6	277	165	171	165
query7	4192	295	299	295
query8	303	263	245	245
query9	9302	2733	2691	2691
query10	453	275	259	259
query11	17873	15170	15263	15170
query12	145	104	105	104
query13	1562	424	408	408
query14	9432	7103	7392	7103
query15	248	169	175	169
query16	7438	441	512	441
query17	1617	589	587	587
query18	1989	315	314	314
query19	292	152	153	152
query20	128	112	115	112
query21	223	111	119	111
query22	4726	4738	4534	4534
query23	34862	34150	34241	34150
query24	11085	2786	2814	2786
query25	642	414	407	407
query26	1386	160	162	160
query27	2402	281	293	281
query28	7130	2415	2404	2404
query29	906	430	424	424
query30	260	159	149	149
query31	1046	821	815	815
query32	102	55	60	55
query33	770	299	303	299
query34	953	500	513	500
query35	898	750	771	750
query36	1130	931	960	931
query37	152	91	89	89
query38	4071	3959	3913	3913
query39	1485	1435	1421	1421
query40	255	100	101	100
query41	49	48	46	46
query42	127	102	102	102
query43	542	485	495	485
query44	1216	801	797	797
query45	197	168	171	168
query46	1130	703	708	703
query47	1927	1850	1802	1802
query48	422	326	329	326
query49	1027	434	423	423
query50	844	383	375	375
query51	7195	6965	6924	6924
query52	101	92	90	90
query53	259	180	178	178
query54	1119	438	429	429
query55	81	79	76	76
query56	282	267	258	258
query57	1326	1181	1179	1179
query58	264	264	231	231
query59	3196	3195	3199	3195
query60	295	259	264	259
query61	99	98	97	97
query62	857	660	654	654
query63	214	187	192	187
query64	5010	654	617	617
query65	3307	3233	3248	3233
query66	1393	301	307	301
query67	15995	15515	15523	15515
query68	4585	553	555	553
query69	553	282	290	282
query70	1189	1146	1157	1146
query71	370	274	279	274
query72	7154	4008	3896	3896
query73	778	346	357	346
query74	10445	9153	8970	8970
query75	3404	2681	2666	2666
query76	3280	971	886	886
query77	412	310	297	297
query78	10701	9627	9543	9543
query79	1198	597	593	593
query80	2367	462	449	449
query81	586	245	236	236
query82	414	143	134	134
query83	300	136	137	136
query84	277	72	71	71
query85	1500	322	290	290
query86	397	309	293	293
query87	4572	4309	4278	4278
query88	3665	2195	2157	2157
query89	400	288	293	288
query90	2138	185	184	184
query91	137	101	101	101
query92	62	48	48	48
query93	1118	547	540	540
query94	1156	299	287	287
query95	346	245	243	243
query96	608	275	273	273
query97	3265	3143	3140	3140
query98	217	199	193	193
query99	1538	1303	1301	1301
Total cold run time: 301595 ms
Total hot run time: 192083 ms

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

ClickBench: Total hot run time: 32.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 12f21412445af504a074197c33e844ee3c4fcbc7, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.54	0.50	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.51	0.53
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.60	0.59
query14	2.78	2.83	2.71
query15	0.91	0.83	0.82
query16	0.41	0.39	0.37
query17	1.02	1.06	1.05
query18	0.20	0.19	0.20
query19	1.82	1.91	1.98
query20	0.01	0.02	0.01
query21	15.37	0.60	0.59
query22	2.64	2.02	1.73
query23	16.83	1.15	0.77
query24	3.66	0.59	1.80
query25	0.17	0.25	0.12
query26	0.60	0.13	0.14
query27	0.04	0.04	0.03
query28	10.17	1.09	1.08
query29	12.54	3.29	3.29
query30	0.24	0.06	0.06
query31	2.87	0.38	0.38
query32	3.28	0.45	0.45
query33	2.98	3.02	3.02
query34	17.01	4.46	4.47
query35	4.55	4.44	4.51
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.96 s
Total hot run time: 32.35 s

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

TeamCity be ut coverage result:
Function Coverage: 37.46% (9699/25891)
Line Coverage: 28.70% (80496/280476)
Region Coverage: 28.15% (41657/147990)
Branch Coverage: 24.71% (21163/85638)
Coverage Report: http://coverage.selectdb-in.cc/coverage/12f21412445af504a074197c33e844ee3c4fcbc7_12f21412445af504a074197c33e844ee3c4fcbc7/report/index.html

zclllyybb
zclllyybb approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

PR approved by at least one committer and no changes requested.

@HappenLee HappenLee merged commit 50bc168 into apache:master Oct 22, 2024
@wyxxxcat wyxxxcat mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wyxxxcat @doris-robot @HappenLee @zclllyybb