Skip to content

[fix](metrics) fix error result in doris_be_num_io_bytes_read_from_remote #42492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wyxxxcat wants to merge 1 commit into from
Closed

[fix](metrics) fix error result in doris_be_num_io_bytes_read_from_remote #42492

wyxxxcat wants to merge 1 commit into from

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Oct 25, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

config::enable_read_cache_file_directly defaults to false

when config::enable_read_cache_file_directly is true, it will read from cache

before:

# TYPE doris_be_num_io_bytes_read_from_remote counter
doris_be_num_io_bytes_read_from_remote 0

# TYPE doris_be_num_io_bytes_read_from_cache counter
doris_be_num_io_bytes_read_from_cache 2457

# TYPE doris_be_local_bytes_read_total counter
doris_be_local_bytes_read_total 10770

after:

# TYPE doris_be_num_io_bytes_read_from_remote counter
doris_be_num_io_bytes_read_from_remote 2457

# TYPE doris_be_num_io_bytes_read_from_cache counter
doris_be_num_io_bytes_read_from_cache 0

# TYPE doris_be_local_bytes_read_total counter
doris_be_local_bytes_read_total 10770

@doris-robot
Copy link

doris-robot commented Oct 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

wyxxxcat
wyxxxcat commented Oct 25, 2024
View reviewed changes
be/src/vec/exec/scan/new_olap_scanner.cpp
Copy link
Contributor Author

@wyxxxcat wyxxxcat Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file will be fixed same as #42215 #37403

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

PR approved by anyone and no changes requested.

freemandealer
freemandealer approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@freemandealer freemandealer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
update: the issue itself is suspicious, we need to discuss.

freemandealer
freemandealer suggested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is false-positive. Close it maybe @wyxxxcat ?

@wyxxxcat wyxxxcat closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@freemandealer freemandealer freemandealer requested changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wyxxxcat @doris-robot @freemandealer @Yukang-Lian @dataroaring