Skip to content

[fix](metrics) fix error result in doris_be_num_io_bytes_read_from_remote #42492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wyxxxcat wants to merge 1 commit into from
Closed

[fix](metrics) fix error result in doris_be_num_io_bytes_read_from_remote #42492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions be/src/io/cache/cached_remote_file_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,8 @@ Status CachedRemoteFileReader::read_at_impl(size_t offset, Slice result, size_t*
stats.skip_cache = true;
break;
case FileBlock::State::DOWNLOADING:
stats.hit_cache = false;
break;
case FileBlock::State::DOWNLOADED:
stats.hit_cache = false;
break;
}
}
Expand Down
1 change: 1 addition & 0 deletions be/src/vec/exec/scan/new_olap_scanner.cpp
View file
Open in desktop
Copy link
Contributor Author

@wyxxxcat wyxxxcat Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file will be fixed same as #42215 #37403

Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ NewOlapScanner::NewOlapScanner(pipeline::ScanLocalStateBase* parent,
.output_columns {},
.remaining_conjunct_roots {},
.common_expr_ctxs_push_down {},
.rowid_conversion {},
.topn_filter_source_node_ids {},
.filter_block_conjuncts {},
.key_group_cluster_key_idxes {},
Expand Down