Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Oct 28, 2024

Introduced by #41273.

The modification of _max_scan_thread_num is a long story. So, the modification i will describe only contains three timestamp. 1. Before #41273; 2. After #41273; 3. After this pr.

We have two dimension, so i will use a table. The value of the table is the _max_scan_thread_num when queries running serially.

C refers to num of cpu cores.

  1. Before 41273
Engine OLAPScanOperator FileScanOperator
PipelineX min(2C, num_of_scanner) 4
Old-Pipeline 4 4
Non-Pipeline 4 4
  1. After 41273
Engine OLAPScanOperator FileScanOperator
PipelineX min(2C, num_of_scanner) min(2C, num_of_scanner)
Old-Pipeline 4 4
Non-Pipeline 4 4
  1. After this pr
Engine OLAPScanOperator FileScanOperator
PipelineX min(2C, num_of_scanner) 4
Old-Pipeline 4 4
Non-Pipeline 4 4

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

1 similar comment
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.02% (9368/26005)
Line Coverage: 27.58% (76953/278969)
Region Coverage: 26.37% (39531/149907)
Branch Coverage: 23.15% (20108/86844)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f4d462968f2375c3b54d83e0a72c9065d9ed4f55_f4d462968f2375c3b54d83e0a72c9065d9ed4f55/report/index.html

@shuke987 shuke987 requested a review from Gabriel39 October 31, 2024 02:38
RuntimeProfile::Counter* _scale_up_scanners_counter = nullptr;
QueryThreadContext _query_thread_context;
bool _ignore_data_distribution = false;
bool _is_file_scan_operator;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should set default value

@yiguolei yiguolei merged commit 012c2d7 into apache:branch-2.1 Oct 31, 2024
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-remote-scan branch October 31, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants