Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

What problem does this PR solve?

Do same thing with #42633 on master

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.91% (9866/26027)
Line Coverage: 29.09% (82268/282775)
Region Coverage: 28.24% (42342/149933)
Branch Coverage: 24.79% (21441/86492)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b363cb9050c45008dd2d5a32be147d34464c6d09_b363cb9050c45008dd2d5a32be147d34464c6d09/report/index.html

@zhiqiang-hhhh zhiqiang-hhhh marked this pull request as ready for review November 11, 2024 02:34
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.91% (9867/26027)
Line Coverage: 29.09% (82251/282775)
Region Coverage: 28.24% (42340/149933)
Branch Coverage: 24.79% (21438/86492)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2f5d51f5ff7485f08d08814ed37e6b8cee8f9bd8_2f5d51f5ff7485f08d08814ed37e6b8cee8f9bd8/report/index.html

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 11, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit fc0c022 into apache:master Nov 11, 2024
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024

Co-authored-by: zhiqiang-hhhh <hezhiqiang@flywheels.com>
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-remote-scan branch November 11, 2024 13:21
dataroaring pushed a commit that referenced this pull request Nov 11, 2024
Cherry-picked from #43532

Co-authored-by: zhiqiang <seuhezhiqiang@163.com>
Co-authored-by: zhiqiang-hhhh <hezhiqiang@flywheels.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants