Skip to content

[fix](build) Fix Mac compilation error caused by namespace conflict in find_symbols.h #43004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zy-kkk merged 1 commit into from
Oct 31, 2024
Merged

[fix](build) Fix Mac compilation error caused by namespace conflict in find_symbols.h #43004

zy-kkk merged 1 commit into from
Oct 31, 2024

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Oct 31, 2024 •
edited
Loading

From #42488

@doris-robot
Copy link

doris-robot commented Oct 31, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented Oct 31, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 31, 2024

TeamCity be ut coverage result:
Function Coverage: 37.94% (9849/25959)
Line Coverage: 29.20% (82080/281107)
Region Coverage: 28.45% (42354/148855)
Branch Coverage: 25.03% (21520/85984)
Coverage Report: http://coverage.selectdb-in.cc/coverage/797b32f6b0df20881d50305d27edbeaf65ee898f_797b32f6b0df20881d50305d27edbeaf65ee898f/report/index.html

@zy-kkk zy-kkk merged commit c1c9420 into apache:master Oct 31, 2024
@zy-kkk zy-kkk deleted the fix_mac_build_1031_2 branch October 31, 2024 13:32
zy-kkk added a commit to zy-kkk/doris that referenced this pull request Nov 13, 2024
@zy-kkk
[fix](build) Fix Mac compilation error caused by namespace conflict i…
581f065 
…n find_symbols.h (apache#43004)

From apache#42488
cambyzju pushed a commit to cambyzju/incubator-doris that referenced this pull request Nov 14, 2024
@zy-kkk @cambyzju
[fix](build) Fix Mac compilation error caused by namespace conflict i…
fe83c18 
…n find_symbols.h (apache#43004)

From apache#42488
@cambyzju cambyzju mentioned this pull request Nov 14, 2024
Closed
16 tasks
@zy-kkk zy-kkk mentioned this pull request Nov 18, 2024
Merged
16 tasks
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
@zy-kkk
[fix](build) Fix Mac compilation error caused by namespace conflict i…
eee58c7 
…n find_symbols.h (#43004)

From #42488
@github-actions github-actions bot mentioned this pull request Mar 14, 2025
Merged
dataroaring pushed a commit that referenced this pull request Mar 20, 2025
@github-actions @zy-kkk @cambyzju
branch-3.0: [fix](build) Fix Mac compilation error caused by namespac…
3030321 
…e conflict in find_symbols.h #43004 (#49078)

Cherry-picked from #43004

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
Co-authored-by: camby <cambyzhu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.5-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zy-kkk @doris-robot @morningman @zhangstar333 @cambyzju @dataroaring