Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Nov 13, 2024

What problem does this PR solve?

bp:#43004

Issue Number: close #xxx

Related PR: #42488

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 13, 2024

run buildall

@zy-kkk zy-kkk changed the title [fix](build) Fix Mac compilation error caused by namespace conflict in find_symbols.h branch-2.1:[fix](build) Fix Mac compilation error caused by namespace conflict in find_symbols.h Nov 13, 2024
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.34% (9482/26094)
Line Coverage: 27.89% (78097/279983)
Region Coverage: 26.54% (40042/150898)
Branch Coverage: 23.32% (20330/87180)
Coverage Report: http://coverage.selectdb-in.cc/coverage/581f06541fa79aaed9989ae804f7187662a0b299_581f06541fa79aaed9989ae804f7187662a0b299/report/index.html

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 14, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit 39b9b81 into apache:branch-2.1 Nov 14, 2024
@zy-kkk zy-kkk deleted the fix_mac_build_21_1113 branch November 14, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants