Skip to content

Conversation

@DarvenDuan
Copy link
Contributor

@DarvenDuan DarvenDuan commented Oct 31, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Doris can update resource properties in FE, but some properties of resource on BE can't be modified.

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41633 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c4efefdb26f59410c7a1f7512c67e5b4d75097c, data reload: false

------ Round 1 ----------------------------------
q1	17591	7668	7350	7350
q2	2074	161	171	161
q3	10854	1102	1185	1102
q4	10539	833	886	833
q5	7737	3105	3073	3073
q6	237	146	145	145
q7	993	615	592	592
q8	9341	2003	2051	2003
q9	6694	6505	6472	6472
q10	7107	2425	2411	2411
q11	448	249	255	249
q12	410	220	210	210
q13	17772	3038	3003	3003
q14	253	215	204	204
q15	583	507	514	507
q16	662	581	588	581
q17	992	617	562	562
q18	7408	6850	6742	6742
q19	1343	1058	967	967
q20	471	180	185	180
q21	4018	3267	3280	3267
q22	1105	1019	1021	1019
Total cold run time: 108632 ms
Total hot run time: 41633 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7271	7246	7242	7242
q2	328	227	225	225
q3	3080	2998	2996	2996
q4	2192	1885	1811	1811
q5	5768	5824	5790	5790
q6	226	136	139	136
q7	2269	1843	1791	1791
q8	3421	3525	3585	3525
q9	9061	8969	8944	8944
q10	3609	3576	3566	3566
q11	600	481	493	481
q12	838	615	608	608
q13	10230	3222	3214	3214
q14	306	272	264	264
q15	566	537	529	529
q16	680	633	640	633
q17	1883	1622	1619	1619
q18	8309	7744	7794	7744
q19	1720	1558	1572	1558
q20	2154	1878	1888	1878
q21	5576	5360	5394	5360
q22	1157	1118	1038	1038
Total cold run time: 71244 ms
Total hot run time: 60952 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196285 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c4efefdb26f59410c7a1f7512c67e5b4d75097c, data reload: false

query1	1230	925	902	902
query2	6227	2199	2105	2105
query3	10796	3910	4039	3910
query4	68197	29498	23709	23709
query5	4979	441	432	432
query6	407	177	179	177
query7	5642	292	297	292
query8	320	234	222	222
query9	9318	2745	2719	2719
query10	453	270	249	249
query11	17462	15336	15840	15336
query12	165	99	101	99
query13	1541	436	448	436
query14	9747	7590	6608	6608
query15	220	190	181	181
query16	7063	468	460	460
query17	1049	566	565	565
query18	1773	303	312	303
query19	197	152	153	152
query20	116	118	111	111
query21	206	99	100	99
query22	4620	4424	4383	4383
query23	34392	34322	34142	34142
query24	6034	2820	2799	2799
query25	503	393	403	393
query26	652	160	160	160
query27	1688	283	305	283
query28	4014	2489	2453	2453
query29	676	416	423	416
query30	234	151	157	151
query31	983	800	794	794
query32	66	56	57	56
query33	471	279	265	265
query34	940	522	524	522
query35	858	737	710	710
query36	1088	970	970	970
query37	122	78	72	72
query38	4378	4266	4279	4266
query39	1475	1420	1400	1400
query40	203	101	100	100
query41	48	47	47	47
query42	111	102	99	99
query43	550	509	517	509
query44	1171	808	813	808
query45	186	170	169	169
query46	1126	719	701	701
query47	1940	1827	1820	1820
query48	437	311	327	311
query49	749	406	393	393
query50	825	397	405	397
query51	7249	7149	7117	7117
query52	110	90	91	90
query53	263	182	188	182
query54	523	416	402	402
query55	79	74	79	74
query56	263	248	254	248
query57	1308	1161	1138	1138
query58	226	198	205	198
query59	3218	3101	2999	2999
query60	263	253	239	239
query61	98	103	103	103
query62	798	672	690	672
query63	219	190	192	190
query64	1348	645	619	619
query65	3266	3205	3185	3185
query66	695	304	306	304
query67	16042	15889	15637	15637
query68	3433	620	601	601
query69	419	259	255	255
query70	1205	1069	1051	1051
query71	341	251	247	247
query72	6149	4015	4005	4005
query73	791	356	362	356
query74	10108	9086	9051	9051
query75	3425	2686	2687	2686
query76	1807	1077	1136	1077
query77	481	283	278	278
query78	10442	9397	9458	9397
query79	1585	596	610	596
query80	859	435	433	433
query81	526	240	241	240
query82	1296	121	114	114
query83	219	149	145	145
query84	282	70	67	67
query85	878	306	281	281
query86	338	295	290	290
query87	4842	4722	4815	4722
query88	3846	2213	2170	2170
query89	411	297	285	285
query90	1982	190	187	187
query91	135	107	111	107
query92	71	48	50	48
query93	1926	553	549	549
query94	784	290	298	290
query95	344	252	241	241
query96	636	286	272	272
query97	2892	2695	2750	2695
query98	214	203	197	197
query99	1789	1313	1299	1299
Total cold run time: 318072 ms
Total hot run time: 196285 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.94% (9852/25970)
Line Coverage: 29.18% (82112/281405)
Region Coverage: 28.44% (42365/148955)
Branch Coverage: 25.01% (21524/86060)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3c4efefdb26f59410c7a1f7512c67e5b4d75097c_3c4efefdb26f59410c7a1f7512c67e5b4d75097c/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 33.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c4efefdb26f59410c7a1f7512c67e5b4d75097c, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.68	0.10	0.10
query5	0.40	0.39	0.42
query6	1.16	0.66	0.66
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.48	0.50
query10	0.55	0.56	0.54
query11	0.13	0.10	0.11
query12	0.13	0.11	0.12
query13	0.60	0.59	0.59
query14	2.75	2.77	2.74
query15	0.89	0.83	0.83
query16	0.39	0.41	0.40
query17	1.06	0.99	1.05
query18	0.20	0.20	0.20
query19	2.00	1.83	1.93
query20	0.01	0.01	0.01
query21	15.37	0.61	0.59
query22	2.55	2.22	2.48
query23	16.86	0.91	0.93
query24	3.21	1.28	1.80
query25	0.25	0.18	0.14
query26	0.41	0.14	0.13
query27	0.04	0.04	0.04
query28	9.94	1.11	1.07
query29	12.58	3.20	3.18
query30	0.25	0.07	0.06
query31	2.86	0.38	0.38
query32	3.29	0.46	0.45
query33	3.05	3.04	3.02
query34	17.06	4.42	4.50
query35	4.51	4.51	4.45
query36	0.68	0.48	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.27 s
Total hot run time: 33.26 s

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41654 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 25c394c903b5ccadfa256f3b3b070395d6eb1f02, data reload: false

------ Round 1 ----------------------------------
q1	17569	7619	7427	7427
q2	2056	185	167	167
q3	10578	1137	1212	1137
q4	10580	845	844	844
q5	7777	3094	3037	3037
q6	238	148	151	148
q7	1009	634	613	613
q8	9367	2047	2050	2047
q9	7064	6450	6424	6424
q10	7018	2478	2430	2430
q11	461	262	258	258
q12	403	220	213	213
q13	17768	2997	3012	2997
q14	234	217	218	217
q15	573	509	505	505
q16	651	578	584	578
q17	990	504	608	504
q18	7310	6743	6778	6743
q19	1346	1028	932	932
q20	490	180	186	180
q21	4043	3241	3356	3241
q22	1121	1013	1012	1012
Total cold run time: 108646 ms
Total hot run time: 41654 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7356	7387	7332	7332
q2	329	229	227	227
q3	3074	2900	2939	2900
q4	2132	1800	1788	1788
q5	5722	5784	5879	5784
q6	230	147	149	147
q7	2271	1854	1776	1776
q8	3442	3491	3506	3491
q9	8994	8958	8944	8944
q10	3618	3561	3580	3561
q11	607	494	504	494
q12	837	614	609	609
q13	8389	3215	3246	3215
q14	304	279	293	279
q15	580	527	504	504
q16	707	648	659	648
q17	1878	1641	1645	1641
q18	8316	7881	7464	7464
q19	1737	1596	1569	1569
q20	2162	1873	1874	1873
q21	5607	5508	5460	5460
q22	1150	1029	1056	1029
Total cold run time: 69442 ms
Total hot run time: 60735 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196475 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 25c394c903b5ccadfa256f3b3b070395d6eb1f02, data reload: false

query1	1217	899	925	899
query2	6238	2029	2043	2029
query3	10902	4079	4109	4079
query4	67664	29203	23617	23617
query5	4968	446	456	446
query6	397	163	167	163
query7	5557	298	293	293
query8	308	230	225	225
query9	9096	2766	2744	2744
query10	440	266	242	242
query11	17584	15367	15877	15367
query12	152	104	107	104
query13	1531	422	432	422
query14	10475	7166	7231	7166
query15	207	195	191	191
query16	7065	455	491	455
query17	1021	551	575	551
query18	1753	296	297	296
query19	205	151	155	151
query20	121	119	110	110
query21	197	107	100	100
query22	4685	4364	4376	4364
query23	34603	34178	34148	34148
query24	6004	2794	2814	2794
query25	522	412	424	412
query26	658	163	159	159
query27	1658	291	297	291
query28	4040	2457	2430	2430
query29	683	432	428	428
query30	244	154	151	151
query31	990	811	825	811
query32	70	55	55	55
query33	467	269	287	269
query34	911	532	537	532
query35	863	767	723	723
query36	1042	916	967	916
query37	117	75	71	71
query38	4377	4351	4350	4350
query39	1456	1448	1418	1418
query40	198	98	97	97
query41	50	46	47	46
query42	105	96	99	96
query43	535	489	479	479
query44	1184	812	818	812
query45	183	164	165	164
query46	1132	722	693	693
query47	1956	1865	1836	1836
query48	426	322	331	322
query49	733	410	394	394
query50	812	400	400	400
query51	7271	7134	7093	7093
query52	101	91	91	91
query53	264	182	182	182
query54	529	407	408	407
query55	78	82	99	82
query56	244	227	242	227
query57	1268	1172	1138	1138
query58	216	214	203	203
query59	3087	3077	2891	2891
query60	280	245	251	245
query61	102	100	103	100
query62	773	660	679	660
query63	213	188	185	185
query64	1327	641	619	619
query65	3266	3227	3204	3204
query66	712	295	286	286
query67	15959	15741	15669	15669
query68	3780	562	545	545
query69	411	249	261	249
query70	1215	1127	1125	1125
query71	371	245	254	245
query72	6407	3947	4006	3947
query73	750	343	364	343
query74	10232	9083	9029	9029
query75	3399	2669	2667	2667
query76	1810	1081	1010	1010
query77	536	316	284	284
query78	10368	9390	9324	9324
query79	2154	603	597	597
query80	1347	428	432	428
query81	541	241	239	239
query82	1210	120	114	114
query83	156	134	134	134
query84	278	70	68	68
query85	977	297	283	283
query86	386	285	307	285
query87	4825	4819	4631	4631
query88	3650	2188	2185	2185
query89	413	289	290	289
query90	1978	191	183	183
query91	136	103	103	103
query92	68	48	51	48
query93	2537	547	541	541
query94	828	291	295	291
query95	357	245	249	245
query96	627	276	291	276
query97	2942	2675	2711	2675
query98	209	217	192	192
query99	1584	1307	1330	1307
Total cold run time: 319974 ms
Total hot run time: 196475 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 25c394c903b5ccadfa256f3b3b070395d6eb1f02, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.11	0.10
query5	0.41	0.40	0.41
query6	1.17	0.65	0.65
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.56	0.50	0.50
query10	0.55	0.54	0.59
query11	0.16	0.11	0.10
query12	0.13	0.11	0.11
query13	0.60	0.58	0.60
query14	2.72	2.73	2.86
query15	0.89	0.81	0.81
query16	0.39	0.37	0.38
query17	1.02	1.01	1.04
query18	0.19	0.20	0.19
query19	1.92	1.79	1.91
query20	0.02	0.01	0.02
query21	15.36	0.57	0.58
query22	2.55	2.31	1.99
query23	17.44	0.90	0.96
query24	3.49	1.25	1.87
query25	0.21	0.12	0.23
query26	0.56	0.13	0.13
query27	0.04	0.04	0.03
query28	9.94	1.10	1.08
query29	12.58	3.28	3.23
query30	0.25	0.05	0.05
query31	2.89	0.39	0.37
query32	3.26	0.47	0.46
query33	3.00	3.05	3.07
query34	16.94	4.51	4.50
query35	4.58	4.50	4.49
query36	0.66	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.97 s
Total hot run time: 33.05 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (9822/25982)
Line Coverage: 28.98% (81703/281935)
Region Coverage: 28.22% (42120/149240)
Branch Coverage: 24.81% (21375/86162)
Coverage Report: http://coverage.selectdb-in.cc/coverage/25c394c903b5ccadfa256f3b3b070395d6eb1f02_25c394c903b5ccadfa256f3b3b070395d6eb1f02/report/index.html

caiconghui
caiconghui previously approved these changes Nov 5, 2024
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@DarvenDuan
Copy link
Contributor Author

run p0

@DarvenDuan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41490 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be8319cac708877fe57a4205bffdb2442897b2e6, data reload: false

------ Round 1 ----------------------------------
q1	17564	7784	7288	7288
q2	2036	169	155	155
q3	10567	1132	1166	1132
q4	10230	835	856	835
q5	7752	3142	3082	3082
q6	233	144	144	144
q7	1018	599	612	599
q8	9345	1963	2025	1963
q9	6708	6435	6501	6435
q10	7087	2457	2476	2457
q11	459	255	254	254
q12	405	213	206	206
q13	17791	3022	3006	3006
q14	247	208	210	208
q15	557	536	518	518
q16	660	575	554	554
q17	981	563	528	528
q18	7510	6730	6849	6730
q19	1319	1043	1008	1008
q20	468	172	171	171
q21	4015	3219	3229	3219
q22	1129	998	1013	998
Total cold run time: 108081 ms
Total hot run time: 41490 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7333	7267	7323	7267
q2	321	226	223	223
q3	2893	2772	2781	2772
q4	1954	1709	1651	1651
q5	5441	5582	5485	5485
q6	220	139	137	137
q7	2182	1729	1720	1720
q8	3259	3420	3438	3420
q9	8634	8621	8611	8611
q10	3497	3456	3475	3456
q11	591	505	499	499
q12	802	579	573	573
q13	10060	3021	2978	2978
q14	310	260	253	253
q15	556	512	517	512
q16	667	629	649	629
q17	1837	1595	1592	1592
q18	7910	7559	7467	7467
q19	1677	1620	1460	1460
q20	2023	1818	1817	1817
q21	5299	5263	5134	5134
q22	1150	1029	1015	1015
Total cold run time: 68616 ms
Total hot run time: 58671 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191280 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be8319cac708877fe57a4205bffdb2442897b2e6, data reload: false

query1	962	377	386	377
query2	6516	2083	2036	2036
query3	6785	222	208	208
query4	33550	23348	23584	23348
query5	4331	446	437	437
query6	261	178	170	170
query7	4612	295	286	286
query8	283	220	215	215
query9	9577	2728	2735	2728
query10	462	250	251	250
query11	18158	15246	15182	15182
query12	149	100	96	96
query13	1663	435	404	404
query14	9820	7407	7214	7214
query15	298	183	183	183
query16	8129	400	459	400
query17	1782	562	550	550
query18	2143	297	300	297
query19	377	153	151	151
query20	117	108	105	105
query21	206	101	104	101
query22	4848	4343	4500	4343
query23	34878	33977	33907	33907
query24	11141	2713	2829	2713
query25	656	415	401	401
query26	1248	154	158	154
query27	2719	281	283	281
query28	7926	2483	2449	2449
query29	869	423	428	423
query30	321	152	154	152
query31	1048	839	815	815
query32	96	56	59	56
query33	774	278	272	272
query34	980	499	514	499
query35	891	742	738	738
query36	1107	947	941	941
query37	139	79	75	75
query38	4390	4192	4289	4192
query39	1472	1446	1442	1442
query40	200	102	100	100
query41	48	47	49	47
query42	112	102	102	102
query43	540	481	487	481
query44	1256	819	818	818
query45	183	164	166	164
query46	1130	696	704	696
query47	1960	1847	1814	1814
query48	418	344	325	325
query49	1167	414	394	394
query50	797	392	387	387
query51	7302	7188	7258	7188
query52	99	89	85	85
query53	255	178	179	178
query54	1357	424	412	412
query55	80	77	82	77
query56	296	234	225	225
query57	1310	1194	1141	1141
query58	234	202	201	201
query59	3159	3057	3086	3057
query60	276	240	249	240
query61	119	100	106	100
query62	877	672	647	647
query63	207	186	183	183
query64	5308	634	621	621
query65	3294	3200	3232	3200
query66	1440	307	305	305
query67	16212	15708	15992	15708
query68	4974	561	564	561
query69	438	247	254	247
query70	1138	1131	1105	1105
query71	352	246	247	246
query72	6463	3982	4000	3982
query73	764	362	360	360
query74	10267	8915	9005	8915
query75	3440	2661	2656	2656
query76	2915	1204	1004	1004
query77	386	272	267	267
query78	10518	9511	9440	9440
query79	1178	592	600	592
query80	872	418	420	418
query81	552	234	236	234
query82	1288	120	121	120
query83	193	138	133	133
query84	232	72	72	72
query85	1261	304	288	288
query86	362	308	309	308
query87	4856	4619	4625	4619
query88	3347	2174	2153	2153
query89	392	284	293	284
query90	2082	185	180	180
query91	133	109	100	100
query92	57	49	49	49
query93	1067	540	549	540
query94	1012	290	288	288
query95	338	241	242	241
query96	614	273	277	273
query97	2866	2677	2636	2636
query98	212	201	192	192
query99	1528	1290	1326	1290
Total cold run time: 301417 ms
Total hot run time: 191280 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.94 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be8319cac708877fe57a4205bffdb2442897b2e6, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.65	0.10	0.10
query5	0.42	0.42	0.40
query6	1.14	0.65	0.64
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.56	0.50	0.49
query10	0.54	0.54	0.57
query11	0.17	0.11	0.10
query12	0.14	0.11	0.10
query13	0.60	0.58	0.59
query14	2.70	2.86	2.74
query15	0.90	0.83	0.82
query16	0.38	0.37	0.37
query17	0.96	1.02	1.06
query18	0.23	0.23	0.22
query19	1.93	1.87	1.93
query20	0.00	0.01	0.01
query21	15.37	0.60	0.58
query22	3.11	2.20	2.09
query23	16.89	0.83	0.86
query24	3.27	1.32	1.19
query25	0.27	0.13	0.09
query26	0.31	0.14	0.13
query27	0.05	0.05	0.05
query28	10.63	1.08	1.07
query29	12.56	3.30	3.24
query30	0.24	0.07	0.06
query31	2.88	0.38	0.37
query32	3.29	0.45	0.46
query33	2.97	3.01	3.01
query34	16.91	4.45	4.42
query35	4.49	4.44	4.49
query36	0.64	0.47	0.48
query37	0.09	0.06	0.05
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.04 s
Total hot run time: 32.94 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.86% (9838/25982)
Line Coverage: 29.03% (81831/281844)
Region Coverage: 28.27% (42167/149155)
Branch Coverage: 24.85% (21393/86092)
Coverage Report: http://coverage.selectdb-in.cc/coverage/be8319cac708877fe57a4205bffdb2442897b2e6_be8319cac708877fe57a4205bffdb2442897b2e6/report/index.html

@DarvenDuan
Copy link
Contributor Author

run p0

@DarvenDuan
Copy link
Contributor Author

run cloud_p0

@DarvenDuan DarvenDuan dismissed stale reviews from GoGoWen and caiconghui via d0d5a17 November 6, 2024 06:54
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@DarvenDuan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.89% (9848/25989)
Line Coverage: 29.04% (81866/281894)
Region Coverage: 28.27% (42177/149173)
Branch Coverage: 24.86% (21400/86098)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d0d5a1739b2d83d98d8ea64e49c29104939a9538_d0d5a1739b2d83d98d8ea64e49c29104939a9538/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 41730 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d0d5a1739b2d83d98d8ea64e49c29104939a9538, data reload: false

------ Round 1 ----------------------------------
q1	17557	7501	7401	7401
q2	2045	179	174	174
q3	10569	1097	1172	1097
q4	10600	872	849	849
q5	7775	3140	3048	3048
q6	235	141	144	141
q7	1013	606	609	606
q8	9371	2003	2114	2003
q9	6715	6489	6462	6462
q10	7042	2397	2413	2397
q11	462	256	252	252
q12	404	216	210	210
q13	17789	3018	3033	3018
q14	238	215	206	206
q15	588	524	519	519
q16	649	591	611	591
q17	976	546	525	525
q18	7464	6710	6703	6703
q19	1346	1053	1054	1053
q20	464	179	178	178
q21	4044	3378	3303	3303
q22	1091	994	1034	994
Total cold run time: 108437 ms
Total hot run time: 41730 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7287	7369	7305	7305
q2	351	244	253	244
q3	3056	2981	3010	2981
q4	2114	1864	1777	1777
q5	5793	5809	5883	5809
q6	223	144	144	144
q7	2293	1863	1811	1811
q8	3717	3580	3568	3568
q9	9014	9061	8942	8942
q10	3648	3592	3573	3573
q11	606	509	524	509
q12	841	598	615	598
q13	9715	3215	3199	3199
q14	301	295	275	275
q15	635	559	546	546
q16	677	659	655	655
q17	1865	1664	1628	1628
q18	8311	7870	7742	7742
q19	1719	1558	1630	1558
q20	2108	1883	1892	1883
q21	5627	5502	5579	5502
q22	1159	1066	1062	1062
Total cold run time: 71060 ms
Total hot run time: 61311 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195091 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d0d5a1739b2d83d98d8ea64e49c29104939a9538, data reload: false

query1	2353	2069	2096	2069
query2	6231	2058	2058	2058
query3	15036	10940	232	232
query4	33397	23881	23525	23525
query5	3422	457	452	452
query6	276	187	187	187
query7	3970	299	301	299
query8	295	235	227	227
query9	9465	2672	2664	2664
query10	461	243	243	243
query11	17897	15303	15228	15228
query12	156	101	97	97
query13	1562	423	426	423
query14	9706	7085	7623	7085
query15	260	182	193	182
query16	7586	493	476	476
query17	1536	607	578	578
query18	2292	624	624	624
query19	345	191	194	191
query20	127	120	121	120
query21	208	104	104	104
query22	4620	4530	4286	4286
query23	35135	34239	34330	34239
query24	11567	3369	3321	3321
query25	638	412	419	412
query26	1374	176	178	176
query27	2205	284	293	284
query28	7420	2441	2448	2441
query29	887	424	429	424
query30	398	315	300	300
query31	1032	789	809	789
query32	93	56	59	56
query33	768	292	280	280
query34	954	518	515	515
query35	893	774	749	749
query36	1114	957	936	936
query37	122	73	74	73
query38	4374	4432	4320	4320
query39	1468	1424	1394	1394
query40	254	101	99	99
query41	48	47	46	46
query42	106	97	101	97
query43	546	488	497	488
query44	1291	823	829	823
query45	183	163	165	163
query46	1139	710	697	697
query47	1923	1838	1887	1838
query48	414	326	331	326
query49	913	414	403	403
query50	818	401	395	395
query51	7336	7120	7169	7120
query52	99	92	86	86
query53	254	181	183	181
query54	1219	420	433	420
query55	78	79	78	78
query56	274	252	258	252
query57	1300	1187	1177	1177
query58	235	200	194	194
query59	3252	3189	2979	2979
query60	269	247	248	247
query61	110	103	109	103
query62	905	673	673	673
query63	228	188	203	188
query64	4282	645	622	622
query65	3307	3206	3188	3188
query66	991	304	315	304
query67	15786	15714	15642	15642
query68	4782	583	588	583
query69	434	249	248	248
query70	1107	1168	1117	1117
query71	324	268	261	261
query72	6259	4092	4078	4078
query73	765	363	370	363
query74	10481	8989	9038	8989
query75	3451	2718	2681	2681
query76	2762	1013	1079	1013
query77	384	273	276	273
query78	10476	9470	9356	9356
query79	1372	595	606	595
query80	1067	430	434	430
query81	562	240	239	239
query82	1154	118	116	116
query83	241	162	160	160
query84	231	72	83	72
query85	1362	307	292	292
query86	393	300	265	265
query87	4800	4714	4766	4714
query88	3551	2211	2203	2203
query89	410	288	294	288
query90	1934	188	191	188
query91	133	102	102	102
query92	56	47	50	47
query93	1517	538	549	538
query94	933	294	299	294
query95	338	252	253	252
query96	628	272	297	272
query97	2927	2696	2676	2676
query98	211	207	193	193
query99	1540	1305	1307	1305
Total cold run time: 305788 ms
Total hot run time: 195091 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.95 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d0d5a1739b2d83d98d8ea64e49c29104939a9538, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.64	0.11	0.11
query5	0.40	0.41	0.42
query6	1.16	0.65	0.64
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.48	0.50
query10	0.55	0.55	0.55
query11	0.14	0.09	0.10
query12	0.14	0.12	0.10
query13	0.61	0.60	0.59
query14	2.80	2.81	2.86
query15	0.89	0.83	0.82
query16	0.40	0.38	0.37
query17	1.05	1.03	1.01
query18	0.20	0.20	0.20
query19	1.99	1.84	2.00
query20	0.02	0.00	0.01
query21	15.37	0.61	0.59
query22	2.79	1.66	1.46
query23	17.29	0.90	0.84
query24	3.17	0.75	1.47
query25	0.21	0.25	0.09
query26	0.50	0.14	0.13
query27	0.03	0.05	0.04
query28	10.49	1.10	1.07
query29	12.56	3.22	3.18
query30	0.25	0.06	0.06
query31	2.87	0.38	0.38
query32	3.28	0.46	0.46
query33	2.98	3.07	2.99
query34	16.93	4.48	4.47
query35	4.47	4.45	4.46
query36	0.68	0.50	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.15	0.12	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.25 s
Total hot run time: 31.95 s

Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@GoGoWen GoGoWen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoGoWen GoGoWen merged commit acea8fc into apache:master Nov 7, 2024
@DarvenDuan DarvenDuan deleted the fix_update_s3_conf branch December 10, 2024 11:59
github-actions bot pushed a commit that referenced this pull request Aug 1, 2025
### What problem does this PR solve?
<!--
You need to clearly describe your PR in this part:

1. What problem was fixed (it's best to include specific error reporting
information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what
is it now, why was it modified, and what possible impacts might there
be.
3. What features were added. Why this function was added.
4. Which codes were refactored and why this part of the code was
refactored.
5. Which functions were optimized and what is the difference before and
after the optimization.

The description of the PR needs to enable reviewers to quickly and
clearly understand the logic of the code modification.
-->

<!--
If there are related issues, please fill in the issue number.
- If you want the issue to be closed after the PR is merged, please use
"close #12345". Otherwise, use "ref #12345"
-->
Issue Number: close #xxx

<!--
If this PR is followup a preivous PR, for example, fix the bug that
introduced by a related PR,
link the PR here
-->
Related PR: #xxx

Problem Summary:
Doris can update resource properties in FE, but some properties of
resource on BE can't be modified.

### Check List (For Committer)

- Test <!-- At least one of them must be included. -->

    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [x] Previous test can cover this change.
        - [ ] No colde files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:

    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?

    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- Release note

    <!-- bugfix, feat, behavior changed need a release note -->
    <!-- Add one line release note for this PR. -->
    None

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
github-actions bot pushed a commit that referenced this pull request Aug 1, 2025
### What problem does this PR solve?
<!--
You need to clearly describe your PR in this part:

1. What problem was fixed (it's best to include specific error reporting
information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what
is it now, why was it modified, and what possible impacts might there
be.
3. What features were added. Why this function was added.
4. Which codes were refactored and why this part of the code was
refactored.
5. Which functions were optimized and what is the difference before and
after the optimization.

The description of the PR needs to enable reviewers to quickly and
clearly understand the logic of the code modification.
-->

<!--
If there are related issues, please fill in the issue number.
- If you want the issue to be closed after the PR is merged, please use
"close #12345". Otherwise, use "ref #12345"
-->
Issue Number: close #xxx

<!--
If this PR is followup a preivous PR, for example, fix the bug that
introduced by a related PR,
link the PR here
-->
Related PR: #xxx

Problem Summary:
Doris can update resource properties in FE, but some properties of
resource on BE can't be modified.

### Check List (For Committer)

- Test <!-- At least one of them must be included. -->

    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [x] Previous test can cover this change.
        - [ ] No colde files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:

    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?

    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- Release note

    <!-- bugfix, feat, behavior changed need a release note -->
    <!-- Add one line release note for this PR. -->
    None

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
morrySnow pushed a commit that referenced this pull request Aug 4, 2025
…3025 (#54228)

Cherry-picked from #43025

Co-authored-by: Xujian Duan <50550370+DarvenDuan@users.noreply.github.com>
dataroaring pushed a commit that referenced this pull request Aug 12, 2025
…3025 (#54211)

Cherry-picked from #43025

Co-authored-by: Xujian Duan <50550370+DarvenDuan@users.noreply.github.com>
@dataroaring dataroaring added dev/3.0.8-merged usercase Important user case type label and removed dev/3.0.x labels Aug 12, 2025
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.8-merged dev/3.1.0-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants