Skip to content

branch-3.1: [fix](resource) fix can't update BE s3 resource config #43025 #54228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 4, 2025
Merged

branch-3.1: [fix](resource) fix can't update BE s3 resource config #43025 #54228

morrySnow merged 1 commit into from
Aug 4, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 1, 2025

Cherry-picked from #43025

@DarvenDuan
[fix](resource) fix can't update BE s3 resource config (#43025)
c772516 
### What problem does this PR solve?
<!--
You need to clearly describe your PR in this part:

1. What problem was fixed (it's best to include specific error reporting
information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what
is it now, why was it modified, and what possible impacts might there
be.
3. What features were added. Why this function was added.
4. Which codes were refactored and why this part of the code was
refactored.
5. Which functions were optimized and what is the difference before and
after the optimization.

The description of the PR needs to enable reviewers to quickly and
clearly understand the logic of the code modification.
-->

<!--
If there are related issues, please fill in the issue number.
- If you want the issue to be closed after the PR is merged, please use
"close #12345". Otherwise, use "ref #12345"
-->
Issue Number: close #xxx

<!--
If this PR is followup a preivous PR, for example, fix the bug that
introduced by a related PR,
link the PR here
-->
Related PR: #xxx

Problem Summary:
Doris can update resource properties in FE, but some properties of
resource on BE can't be modified.

### Check List (For Committer)

- Test <!-- At least one of them must be included. -->

    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [x] Previous test can cover this change.
        - [ ] No colde files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:

    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?

    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- Release note

    <!-- bugfix, feat, behavior changed need a release note -->
    <!-- Add one line release note for this PR. -->
    None

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from morrySnow as a code owner August 1, 2025 14:43
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Aug 1, 2025
@dataroaring dataroaring reopened this Aug 1, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 1, 2025

TPC-H: Total hot run time: 32679 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c7725160098c78a005b07dc8483f52e7da01910c, data reload: false

------ Round 1 ----------------------------------
q1	17588	5499	5431	5431
q2	2058	301	169	169
q3	10443	1258	736	736
q4	10227	887	446	446
q5	8106	2379	2112	2112
q6	189	162	131	131
q7	917	757	614	614
q8	9324	1515	1258	1258
q9	5165	4934	4922	4922
q10	6761	2253	1789	1789
q11	477	280	261	261
q12	337	352	208	208
q13	17773	3635	2995	2995
q14	217	224	214	214
q15	522	476	463	463
q16	431	425	376	376
q17	619	899	362	362
q18	6807	6534	6490	6490
q19	1220	955	547	547
q20	340	349	201	201
q21	2791	2134	1953	1953
q22	1079	1061	1001	1001
Total cold run time: 103391 ms
Total hot run time: 32679 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5712	5631	5614	5614
q2	239	334	237	237
q3	2192	2617	2306	2306
q4	1401	1766	1345	1345
q5	4356	4793	4996	4793
q6	174	163	128	128
q7	2065	1947	1826	1826
q8	2651	2833	2695	2695
q9	7223	7190	7240	7190
q10	3010	3324	2857	2857
q11	557	496	481	481
q12	621	749	609	609
q13	3427	3820	3189	3189
q14	272	293	278	278
q15	515	464	471	464
q16	436	480	419	419
q17	1261	1735	1251	1251
q18	7538	7541	7339	7339
q19	810	1155	1154	1154
q20	2040	2027	1884	1884
q21	5290	4861	4679	4679
q22	1048	1062	1001	1001
Total cold run time: 52838 ms
Total hot run time: 51739 ms

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 1, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.42% (12637/27822)
Line Coverage 36.26% (112621/310616)
Region Coverage 35.30% (58203/164887)
Branch Coverage 32.50% (31657/97408)

@doris-robot
Copy link

doris-robot commented Aug 1, 2025

TPC-DS: Total hot run time: 197040 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c7725160098c78a005b07dc8483f52e7da01910c, data reload: false

query1	1307	934	923	923
query2	6265	1972	1953	1953
query3	10945	4482	4558	4482
query4	33192	23756	23588	23588
query5	4036	628	510	510
query6	283	201	178	178
query7	3987	505	324	324
query8	305	252	241	241
query9	9316	2651	2589	2589
query10	504	344	262	262
query11	18114	15385	15197	15197
query12	158	110	105	105
query13	1568	531	423	423
query14	9370	7035	6688	6688
query15	227	218	179	179
query16	7958	644	480	480
query17	1557	767	590	590
query18	2129	400	299	299
query19	198	192	156	156
query20	127	117	116	116
query21	205	124	106	106
query22	4736	4798	4521	4521
query23	34757	34125	34211	34125
query24	7244	2699	2741	2699
query25	554	493	427	427
query26	930	288	173	173
query27	2421	472	363	363
query28	5715	2240	2199	2199
query29	745	618	473	473
query30	251	187	163	163
query31	977	896	827	827
query32	79	65	62	62
query33	511	370	325	325
query34	747	851	526	526
query35	788	826	755	755
query36	1036	1051	989	989
query37	103	96	67	67
query38	3976	4051	3986	3986
query39	1526	1460	1486	1460
query40	212	119	109	109
query41	53	57	53	53
query42	138	111	102	102
query43	516	520	495	495
query44	1335	822	835	822
query45	194	183	172	172
query46	891	1087	687	687
query47	1977	2016	1930	1930
query48	431	455	345	345
query49	812	541	425	425
query50	680	693	447	447
query51	7485	7382	7219	7219
query52	101	96	89	89
query53	238	268	186	186
query54	570	532	482	482
query55	81	80	83	80
query56	265	264	256	256
query57	1267	1246	1207	1207
query58	236	230	228	228
query59	3142	3212	3030	3030
query60	294	301	273	273
query61	118	116	110	110
query62	810	764	717	717
query63	243	199	189	189
query64	4062	1026	698	698
query65	3327	3267	3304	3267
query66	1024	409	298	298
query67	16030	15931	15594	15594
query68	7754	821	547	547
query69	511	302	264	264
query70	1165	1121	1078	1078
query71	400	298	262	262
query72	5813	3682	3824	3682
query73	650	743	357	357
query74	10417	9360	8906	8906
query75	3184	3151	2643	2643
query76	3105	1180	773	773
query77	481	354	287	287
query78	10294	10429	9557	9557
query79	3620	899	590	590
query80	702	521	427	427
query81	510	270	222	222
query82	615	118	90	90
query83	173	161	143	143
query84	284	111	83	83
query85	782	390	308	308
query86	350	315	313	313
query87	4384	4306	4312	4306
query88	4726	2432	2419	2419
query89	419	331	296	296
query90	1815	191	188	188
query91	134	137	112	112
query92	66	55	54	54
query93	1377	872	531	531
query94	701	404	316	316
query95	339	275	267	267
query96	498	611	284	284
query97	3217	3309	3159	3159
query98	233	212	198	198
query99	1617	1427	1339	1339
Total cold run time: 295715 ms
Total hot run time: 197040 ms

@doris-robot
Copy link

doris-robot commented Aug 1, 2025

ClickBench: Total hot run time: 29.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c7725160098c78a005b07dc8483f52e7da01910c, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.11	0.11
query5	0.53	0.54	0.53
query6	1.16	0.74	0.73
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.56	0.52	0.50
query10	0.57	0.54	0.57
query11	0.14	0.10	0.10
query12	0.13	0.11	0.12
query13	0.61	0.59	0.58
query14	0.77	0.79	0.79
query15	0.85	0.84	0.83
query16	0.39	0.38	0.38
query17	1.07	1.06	0.99
query18	0.24	0.22	0.22
query19	1.91	1.89	1.87
query20	0.02	0.01	0.01
query21	15.39	0.95	0.57
query22	0.76	0.78	0.59
query23	15.22	1.40	0.57
query24	2.93	1.31	1.09
query25	0.14	0.26	0.05
query26	0.31	0.14	0.14
query27	0.07	0.08	0.04
query28	13.74	1.00	0.43
query29	12.57	3.96	3.34
query30	0.25	0.10	0.07
query31	2.82	0.60	0.37
query32	3.24	0.53	0.44
query33	3.06	3.02	3.02
query34	16.53	5.15	4.58
query35	4.57	4.56	4.56
query36	0.65	0.49	0.50
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.02	0.03
Total cold run time: 103.74 s
Total hot run time: 29.11 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 1, 2025

BE Regression && UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.23% (20955/27489)
Line Coverage 69.61% (216088/310408)
Region Coverage 67.65% (129372/191224)
Branch Coverage 61.22% (67299/109932)

@morrySnow morrySnow merged commit 3706269 into branch-3.1 Aug 4, 2025
21 of 23 checks passed
@github-actions github-actions bot deleted the auto-pick-43025-branch-3.1 branch August 4, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @DarvenDuan