[Refactor](BE) Uniform Expr, Block, Columns size-relative interface (Part II) #43218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BiteTheDDDDt
pushed a commit
that referenced
this pull request
Nov 8, 2024
…Part I) (#42930) ## Proposed changes In this pr we refactored some base interface to avoid narrow cast with data consistent kept. We uniformed these type of numbers: ``` columns in Block - U32 (just use no more than U16) Rows in Block - U64 (others U32, ColumnString64 U64) column_id in expr arg - I32 (because -1 is meaningful) child of Expr - U16 (FE use int32, have a restriction of 10000. adjustable but no guarantee for result) ``` So, for functions' argument column id, we use `uint32` to replace `size_t`. For rows, we use `size_t` to replace some `int`. For child of expr, we cast it as `uint_16` to use, rather than `size_t` as `vector::size()` Refactor of table functions: #43218
Contributor
Author
|
run buildall |
Mryange
approved these changes
Nov 8, 2024
Contributor
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
16 tasks
924060929
added a commit
that referenced
this pull request
Nov 18, 2024
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Nov 18, 2024
fix macos compile failed, introduced by apache#40813, apache#42930, apache#43218, apache#43289 (cherry picked from commit ded2190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 2 of #42930
two modifications: