Skip to content

[Refactor](BE) Uniform Expr, Block, Columns size-relative interface (Part I) #42930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 3 commits into from
Nov 8, 2024
Merged

[Refactor](BE) Uniform Expr, Block, Columns size-relative interface (Part I) #42930

BiteTheDDDDt merged 3 commits into from
Nov 8, 2024

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Oct 30, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

In this pr we refactored some base interface to avoid narrow cast with data consistent kept.

We uniformed these type of numbers:

columns in Block        - U32 (just use no more than U16)
Rows in Block           - U64 (others U32, ColumnString64 U64)
column_id in expr arg   - I32 (because -1 is meaningful)
child of Expr           - U16 (FE use int32, have a restriction of 10000. adjustable but no guarantee for result)

So, for functions' argument column id, we use uint32 to replace size_t.
For rows, we use size_t to replace some int.
For child of expr, we cast it as uint_16 to use, rather than size_t as vector::size()

Refactor of table functions: #43218

@doris-robot
Copy link

doris-robot commented Oct 30, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Oct 30, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@doris-robot
Copy link

doris-robot commented Oct 30, 2024

TeamCity be ut coverage result:
Function Coverage: 37.89% (9845/25986)
Line Coverage: 29.17% (82001/281131)
Region Coverage: 28.54% (42307/148245)
Branch Coverage: 25.05% (21492/85782)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1cf40cf76bac09d42c7fbb44faf39859eb42cca2_1cf40cf76bac09d42c7fbb44faf39859eb42cca2/report/index.html

Mryange
Mryange reviewed Oct 31, 2024
View reviewed changes
HappenLee
HappenLee reviewed Oct 31, 2024
View reviewed changes
Mryange
Mryange reviewed Oct 31, 2024
View reviewed changes
HappenLee
HappenLee reviewed Oct 31, 2024
View reviewed changes
HappenLee
HappenLee reviewed Oct 31, 2024
View reviewed changes
HappenLee
HappenLee reviewed Oct 31, 2024
View reviewed changes
HappenLee
HappenLee reviewed Oct 31, 2024
View reviewed changes
HappenLee
HappenLee reviewed Oct 31, 2024
View reviewed changes
HappenLee
HappenLee reviewed Oct 31, 2024
View reviewed changes
@zclllyybb zclllyybb force-pushed the compile_check branch 2 times, most recently from 144d6bb to 5c78d09 Compare November 4, 2024 07:45
@zclllyybb zclllyybb changed the title [chore](BE) Add some compile time check to some files [Refactor](BE) Uniform Expr, Block, Columns size-relative interface Nov 4, 2024
@zclllyybb zclllyybb changed the title [Refactor](BE) Uniform Expr, Block, Columns size-relative interface [Refactor](BE) Uniform Expr, Block, Columns size-relative interface (Part I) Nov 4, 2024
github-actions[bot]
github-actions bot reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 4, 2024

run buildall

@zclllyybb zclllyybb mentioned this pull request Nov 4, 2024
Merged
@doris-robot
Copy link

doris-robot commented Nov 4, 2024

TeamCity be ut coverage result:
Function Coverage: 37.81% (9821/25975)
Line Coverage: 28.98% (81682/281811)
Region Coverage: 28.23% (42110/149182)
Branch Coverage: 24.81% (21370/86134)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5fdc30f32705d0d9d24d438cd55b0c0b9278da84_5fdc30f32705d0d9d24d438cd55b0c0b9278da84/report/index.html

Mryange
Mryange reviewed Nov 5, 2024
View reviewed changes
Mryange
Mryange reviewed Nov 5, 2024
View reviewed changes
Mryange
Mryange reviewed Nov 5, 2024
View reviewed changes
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 5, 2024

run buildall

@zclllyybb zclllyybb requested a review from Mryange November 5, 2024 05:04
@doris-robot
Copy link

doris-robot commented Nov 5, 2024

TeamCity be ut coverage result:
Function Coverage: 37.80% (9820/25982)
Line Coverage: 28.96% (81651/281927)
Region Coverage: 28.22% (42106/149227)
Branch Coverage: 24.79% (21360/86158)
Coverage Report: http://coverage.selectdb-in.cc/coverage/44846765b78af1e279faedbd124aa16092f8450f_44846765b78af1e279faedbd124aa16092f8450f/report/index.html

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 6, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

HappenLee
HappenLee approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Nov 6, 2024

TeamCity be ut coverage result:
Function Coverage: 37.88% (9849/26001)
Line Coverage: 29.04% (81914/282026)
Region Coverage: 28.27% (42194/149229)
Branch Coverage: 24.86% (21410/86130)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c94a3b35e99ed798af16491535e2d1ff61ee8e54_c94a3b35e99ed798af16491535e2d1ff61ee8e54/report/index.html

@BiteTheDDDDt BiteTheDDDDt merged commit c86498d into apache:master Nov 8, 2024
@zclllyybb zclllyybb deleted the compile_check branch November 8, 2024 06:17
zhangstar333 pushed a commit that referenced this pull request Nov 11, 2024
@zclllyybb
[Refactor](BE) Uniform Expr, Block, Columns size-relative interface (…
279c162 
…Part II) (#43218)

part 2 of #42930

two modifications:
1. when parsing data of json array, cast to target type when parse int
data no matter what source type is.
2. in explode_numbers, the argument column type is certain Int32. so
reduce some virtual function call.
@zy-kkk zy-kkk mentioned this pull request Nov 11, 2024
Closed
16 tasks
@924060929 924060929 mentioned this pull request Nov 15, 2024
Merged
16 tasks
924060929 added a commit that referenced this pull request Nov 18, 2024
@924060929
[fix](compile) fix macos compile failed (#44061)
ded2190 
fix macos compile failed, introduced by #40813, #42930, #43218, #43289
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Nov 18, 2024
@924060929
[fix](compile) fix macos compile failed (apache#44061)
46390d5 
fix macos compile failed, introduced by apache#40813, apache#42930, apache#43218, apache#43289

(cherry picked from commit ded2190)
924060929 added a commit that referenced this pull request Nov 18, 2024
@924060929
[fix](compile) fix macos compile failed (#44061) (#44201)
7d50da9 
fix macos compile failed, introduced by #40813, #42930, #43218, #43289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@HappenLee HappenLee HappenLee approved these changes

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zclllyybb @doris-robot @HappenLee @Mryange @BiteTheDDDDt @zhangstar333