Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Nov 11, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #40813,#43289,#42930

Problem Summary:
Some types cannot be implicitly converted on MacOS and require explicit cast to ensure compilation

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 11, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 12, 2024

run buildall

@zy-kkk zy-kkk force-pushed the fix_mac_build_1111 branch from e952cdc to c641d50 Compare November 12, 2024 14:30
@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 12, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zy-kkk zy-kkk force-pushed the fix_mac_build_1111 branch from ddb952b to 580ec70 Compare November 13, 2024 14:25
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 14, 2024

run buildall

@zy-kkk zy-kkk force-pushed the fix_mac_build_1111 branch from 580ec70 to 6b165d0 Compare November 18, 2024 02:03
@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 18, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.97% (9897/26067)
Line Coverage: 29.16% (82715/283668)
Region Coverage: 28.30% (42483/150135)
Branch Coverage: 24.88% (21547/86612)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6b165d06c4ef9c2347951ebd44f556108a85bfc2_6b165d06c4ef9c2347951ebd44f556108a85bfc2/report/index.html

@zy-kkk zy-kkk closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants