[fix](cloud) Check instance_id valid when use cloud_unique_id degrade format #43253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run builldall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (c0 != TxnErrorCode::TXN_OK) { | ||
| LOG(WARNING) << "check instance instance_id=" << instance_id | ||
| << " failed, code=" << format_as(c0) << ", info=" + m0; | ||
| return false; |
Contributor
There was a problem hiding this comment.
warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
cloud/src/resource-manager/resource_manager.cpp:227:
- if (c0 != TxnErrorCode::TXN_OK) {
- LOG(WARNING) << "check instance instance_id=" << instance_id
- << " failed, code=" << format_as(c0) << ", info=" + m0;
- return false;
- }
- return true;
+ return !c0 != TxnErrorCode::TXN_OK;
dataroaring
reviewed
Nov 6, 2024
dataroaring
reviewed
Nov 6, 2024
gavinchou
requested changes
Nov 6, 2024
Contributor
Author
|
run buildall |
gavinchou
previously approved these changes
Nov 8, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
Author
|
run cloudut |
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Nov 11, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
gavinchou
changed the title
zzzxl1993
pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Nov 12, 2024
924060929
pushed a commit
to 924060929/incubator-doris
that referenced
this pull request
Nov 12, 2024
deardeng
added a commit
to deardeng/incubator-doris
that referenced
this pull request
Nov 13, 2024
py023
pushed a commit
to py023/doris
that referenced
this pull request
Nov 13, 2024
dataroaring
added
dev/3.0.3-merged
and removed
dev/3.0.x
cherry-pick-conflict-in-3.0
labels
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Check List (For Committer)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)