[fix](cloud) Check instance_id valid when use cloud_unique_id degrade format #43253 #43832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::pair<bool, std::string> ResourceManager::get_instance_id_by_cloud_unique_id( | ||
| const std::string& cloud_unique_id) { | ||
| auto v = split(cloud_unique_id, ':'); | ||
| if (v.size() != 3) return {false, ""}; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (v.size() != 3) return {false, ""}; | |
| if (v.size() != 3) { return {false, ""}; | |
| } |
| if (v.size() != 3) return {false, ""}; | ||
| // degraded format check it | ||
| int version = std::atoi(v[0].c_str()); | ||
| if (version != 1) return {false, ""}; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (version != 1) return {false, ""}; | |
| if (version != 1) { return {false, ""}; | |
| } |
gavinchou
approved these changes
Nov 13, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from #43253